Re: [PATCH v2 0/4] virtio-net: Convert feature properties to OnOffAuto

[Jason Wang]

On Mon, Jul 8, 2024 at 3:38 PM Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> Based-on: <20240428-rss-v10-0-73cbaa91aeb6@daynix.com>
> ("[PATCH v10 00/18] virtio-net RSS/hash report fixes and improvements")
>
> Some features are not always available, and virtio-net used to disable
> them when not available even if the corresponding properties were
> explicitly set to "on".
>
> Convert feature properties to OnOffAuto so that the user can explicitly
> tell QEMU to automatically select the value by setting them "auto".
> QEMU will give an error if they are set "on".

Would this be consumed by a management layer like libvirt?

Thanks

>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> Changes in v2:
> - Added patch "virtio-net: Remove fallback from ebpf-rss-fds".
> - Added a compatibility property.
> - Corrected property type name.
> - Link to v1: 
> https://lore.kernel.org/r/20240428-auto-v1-0-7b012216a120@daynix.com
>
> ---
> Akihiko Odaki (4):
>       qdev-properties: Add DEFINE_PROP_ON_OFF_AUTO_BIT64()
>       virtio-net: Convert feature properties to OnOffAuto
>       virtio-net: Report RSS warning at device realization
>       virtio-net: Remove fallback from ebpf-rss-fds
>
>  include/hw/qdev-properties.h   |  18 +++
>  include/hw/virtio/virtio-net.h |   3 +-
>  hw/core/machine.c              |   1 +
>  hw/core/qdev-properties.c      |  65 +++++++++-
>  hw/net/virtio-net.c            | 278 
> ++++++++++++++++++++++++-----------------
>  5 files changed, 251 insertions(+), 114 deletions(-)
> ---
> base-commit: f2cb4026fccfe073f84a4b440e41d3ed0c3134f6
> change-id: 20240428-auto-be0dc010dda5
>
> Best regards,
> --
> Akihiko Odaki <akihiko.odaki@daynix.com>
>