[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/7] hw/vfio/container: Get rid of qemu_open_old()
From: |
Zhao Liu |
Subject: |
[PATCH 4/7] hw/vfio/container: Get rid of qemu_open_old() |
Date: |
Mon, 15 Jul 2024 16:21:52 +0800 |
For qemu_open_old(), osdep.h said:
> Don't introduce new usage of this function, prefer the following
> qemu_open/qemu_create that take an "Error **errp".
So replace qemu_open_old() with qemu_open().
Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: "Cédric Le Goater" <clg@redhat.com>
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
hw/vfio/container.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/vfio/container.c b/hw/vfio/container.c
index 425db1a14c07..38a9df34964a 100644
--- a/hw/vfio/container.c
+++ b/hw/vfio/container.c
@@ -600,9 +600,8 @@ static bool vfio_connect_container(VFIOGroup *group,
AddressSpace *as,
}
}
- fd = qemu_open_old("/dev/vfio/vfio", O_RDWR);
+ fd = qemu_open("/dev/vfio/vfio", O_RDWR, errp);
if (fd < 0) {
- error_setg_errno(errp, errno, "failed to open /dev/vfio/vfio");
goto put_space_exit;
}
@@ -743,9 +742,8 @@ static VFIOGroup *vfio_get_group(int groupid, AddressSpace
*as, Error **errp)
group = g_malloc0(sizeof(*group));
snprintf(path, sizeof(path), "/dev/vfio/%d", groupid);
- group->fd = qemu_open_old(path, O_RDWR);
+ group->fd = qemu_open(path, O_RDWR, errp);
if (group->fd < 0) {
- error_setg_errno(errp, errno, "failed to open %s", path);
goto free_group_exit;
}
--
2.34.1
- [PATCH 0/7] trivial: Replace some qemu_open_old() with qemu_open(), Zhao Liu, 2024/07/15
- [PATCH 1/7] hw/i386/sgx: Get rid of qemu_open_old(), Zhao Liu, 2024/07/15
- [PATCH 2/7] hw/usb/host-libusb: Get rid of qemu_open_old(), Zhao Liu, 2024/07/15
- [PATCH 3/7] hw/usb/u2f-passthru: Get rid of qemu_open_old(), Zhao Liu, 2024/07/15
- [PATCH 4/7] hw/vfio/container: Get rid of qemu_open_old(),
Zhao Liu <=
- [PATCH 6/7] backends/iommufd: Get rid of qemu_open_old(), Zhao Liu, 2024/07/15
- [PATCH 5/7] backends/hostmem-epc: Get rid of qemu_open_old(), Zhao Liu, 2024/07/15
- [PATCH 7/7] backends/rng-random: Get rid of qemu_open_old(), Zhao Liu, 2024/07/15