Re: [PATCH 6/7] backends/iommufd: Get rid of qemu_open_old()

[Yi Liu]

On 2024/7/15 16:21, Zhao Liu wrote:
> For qemu_open_old(), osdep.h said:
>
> > Don't introduce new usage of this function, prefer the following
> > qemu_open/qemu_create that take an "Error **errp".
>
> So replace qemu_open_old() with qemu_open().
>
> Cc: Yi Liu <yi.l.liu@intel.com>
> Cc: Eric Auger <eric.auger@redhat.com>
> Cc: Zhenzhong Duan <zhenzhong.duan@intel.com>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
>   backends/iommufd.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed-by: Yi Liu <yi.l.liu@intel.com>

> diff --git a/backends/iommufd.c b/backends/iommufd.c
> index 84fefbc9ee7a..cabd1b50025d 100644
> --- a/backends/iommufd.c
> +++ b/backends/iommufd.c
> @@ -77,9 +77,8 @@ bool iommufd_backend_connect(IOMMUFDBackend *be, Error **errp)
>       int fd;
>   
>       if (be->owned && !be->users) {
> -        fd = qemu_open_old("/dev/iommu", O_RDWR);
> +        fd = qemu_open("/dev/iommu", O_RDWR, errp);
>           if (fd < 0) {
> -            error_setg_errno(errp, errno, "/dev/iommu opening failed");
>               return false;
>           }
>           be->fd = fd;

--
Regards,
Yi Liu