Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

[Paolo Bonzini]

Il mar 16 lug 2024, 20:10 Daniel P. Berrangé <berrange@redhat.com> ha scritto:

On Tue, Jul 16, 2024 at 08:03:54PM +0200, Paolo Bonzini wrote:
> Il mar 16 lug 2024, 18:45 John Snow <jsnow@redhat.com> ha scritto:
>
> > My only ask is that we keep the tests running in the custom venv
> > environment we set up at build time
> >
>
> Yes, they do, however pytest should also be added to pythondeps.toml if we
> go this way.

Done in this patch:

  https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg03596.html

That adds pycotap, not pytest.

> Yep, that's the part that I am a bit more doubtful about.

Pulling & caching VM images isn't much more than a URL download to
a local file, not very complex in python. Assuming that's what you
are refering to, then it is already done in this patch:

  https://lists.nongnu.org/archive/html/qemu-devel/2024-07/msg03598.html

I think there are also compressed assets that have to be passed through gzip/xzip/zstd. I am worried that Thomas's patches do 90% of the job but that is not a good estimation of what's left.

Paolo

With regards,
Daniel
--
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|