Re: [PATCH v4 4/4] intel_iommu: make types match

[Michael S. Tsirkin]

On Sat, Jul 20, 2024 at 02:46:14PM -0400, Michael S. Tsirkin wrote:
> On Mon, Jul 08, 2024 at 03:20:45PM +0800, Yi Liu wrote:
> > On 2024/7/5 19:01, CLEMENT MATHIEU--DRIF wrote:
> > > From: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com>
> > > 
> > > The 'level' field in vtd_iotlb_key is an unsigned integer.
> > > We don't need to store level as an int in vtd_lookup_iotlb.
> > > 
> > > This is not an issue by itself, but using unsigned here seems cleaner.
> > 
> > a nit to the subject. s/"make types match"/"make type match"/
> 
> Hmm not sure I agree.
> There are two variables, they have types. We make them match.


ignore pls this is on old version

> 
> > > Signed-off-by: Clément Mathieu--Drif <clement.mathieu--drif@eviden.com>
> > > ---
> > >   hw/i386/intel_iommu.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> > > index 37c21a0aec..be0cb39b5c 100644
> > > --- a/hw/i386/intel_iommu.c
> > > +++ b/hw/i386/intel_iommu.c
> > > @@ -358,7 +358,7 @@ static VTDIOTLBEntry 
> > > *vtd_lookup_iotlb(IntelIOMMUState *s, uint16_t source_id,
> > >   {
> > >       struct vtd_iotlb_key key;
> > >       VTDIOTLBEntry *entry;
> > > -    int level;
> > > +    unsigned level;
> > >       for (level = VTD_SL_PT_LEVEL; level < VTD_SL_PML4_LEVEL; level++) {
> > >           key.gfn = vtd_get_iotlb_gfn(addr, level);
> > 
> > -- 
> > Regards,
> > Yi Liu