Re: [PATCH for-9.0] qapi: drop unused QCryptoBlockCreateOptionsLUKS.detached-header

[Daniel P . Berrangé]

On Tue, Mar 19, 2024 at 05:06:07PM +0100, Markus Armbruster wrote:
> Daniel P. Berrangé <berrange@redhat.com> writes:
> 
> > The 'detached-header' field in QCryptoBlockCreateOptionsLUKS
> > was left over from earlier patch iterations.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >  qapi/crypto.json | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/qapi/crypto.json b/qapi/crypto.json
> > index 931c88e688..ad9e3d0297 100644
> > --- a/qapi/crypto.json
> > +++ b/qapi/crypto.json
> > @@ -226,8 +226,6 @@
> >  # @iter-time: number of milliseconds to spend in PBKDF passphrase
> >  #     processing.  Currently defaults to 2000. (since 2.8)
> >  #
> > -# @detached-header: create a detached LUKS header. (since 9.0)
> > -#
> >  # Since: 2.6
> >  ##
> >  { 'struct': 'QCryptoBlockCreateOptionsLUKS',
> > @@ -237,8 +235,7 @@
> >              '*ivgen-alg': 'QCryptoIVGenAlgorithm',
> >              '*ivgen-hash-alg': 'QCryptoHashAlgorithm',
> >              '*hash-alg': 'QCryptoHashAlgorithm',
> > -            '*iter-time': 'int',
> > -            '*detached-header': 'bool'}}
> > +            '*iter-time': 'int' }}
> >  
> >  ##
> >  # @QCryptoBlockOpenOptions:
> 
> Glad you caught this in time.
> 
> Acked-by: Markus Armbruster <armbru@redhat.com>

Urgh, it appears this patch got lost and was not in fact included in
9.0.  What's your opinion on removing it from 9.1 with no deprecation
period ?  Functionally it did absolutely nothing even if used, so
removing it at most would cause an incorrect field to now be rejected.



With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|