Re: [RFC PATCH v5 8/8] rust/pl011: vendor dependencies

[Manos Pitsidianakis]

On Tue, 23 Jul 2024 11:37, Zhao Liu <zhao1.liu@intel.com> wrote:
> Hi Manos,
>
> (This patch contains too many codes so that mail list rejects to display
> it at https://lore.kernel.org/qemu-devel)
>
> Please correct me if I'm wrong...
>
> Is the reason for not using git submodules here because v5 abandoned
> compilation through Cargo, so it’s necessary to add meson.build to the
> code repository of each dependency, and consequently, all code must be
> loaded into QEMU?
>
> It looks like will be difficult to synchronize the dependency changes
> in the future.

Yes, ideally we want meson wrap files (git submodules were removed in 
2019cabfee). Meson support for that is a bit buggy and might require 
bleeding edge versions, so for the time being I vendored the 
dependencies. Otherwise I'd keep getting delayed posting a new patch 
series and I wanted to have feedback coming in the mean time :)

Manos

> Best Regards,
> Zhao