[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/char/goldfish: Use DMA memory API
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH] hw/char/goldfish: Use DMA memory API |
|
Date: |
Tue, 23 Jul 2024 14:35:54 -0400 |
On Tue, Jul 23, 2024 at 08:18:50PM +0200, Philippe Mathieu-Daudé wrote:
> Rather than using address_space_rw(..., 0 or 1),
> use the simpler DMA memory API which expand to
> the same code. This allows removing a cast on
> the 'buf' variable which is really const. Since
> 'buf' is only used in the CMD_READ_BUFFER case,
> we can reduce its scope.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu