qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hw/char/goldfish: Use DMA memory API


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] hw/char/goldfish: Use DMA memory API
Date: Tue, 23 Jul 2024 22:40:12 +0200
User-agent: Mozilla Thunderbird

On 23/7/24 20:18, Philippe Mathieu-Daudé wrote:
Rather than using address_space_rw(..., 0 or 1),
use the simpler DMA memory API which expand to
the same code. This allows removing a cast on
the 'buf' variable which is really const. Since
'buf' is only used in the CMD_READ_BUFFER case,
we can reduce its scope.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
  hw/char/goldfish_tty.c | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)

Thanks for the quick reviews, patch queued.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]