qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 0/7] Rework x86 page table walks


From: Richard Henderson
Subject: Re: [PATCH v4 0/7] Rework x86 page table walks
Date: Wed, 24 Jul 2024 13:39:08 +1000
User-agent: Mozilla Thunderbird

Hi Don.

In addition to the other issues, this really needs to be broken up into many 
more patches.

Every patch should do *one* thing:

  - Code motion
  - Introduce an API
  - Introduce target-specific support for an API
  - Use an API to implement a monitor command
  - etc

Patch 3, 'Add an "info pg" command ...' attempts to do all of these at once, and so is at least 2000 lines too long, which makes the whole thing extraordinarily hard to review.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]