[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/11] meson: build chardev trace files when have_block
From: |
Daniel P . Berrangé |
Subject: |
[PULL 07/11] meson: build chardev trace files when have_block |
Date: |
Wed, 24 Jul 2024 10:47:02 +0100 |
The QSD depends on chardev code, and is built when have_tools is
true. This means conditionalizing chardev trace on have_system
is wrong, we need have_block which is set have_system || have_tools.
This latent bug was historically harmless because only the spice
chardev included tracing, which wasn't built in a !have_system
scenario.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index ec6fb7d69c..5613b62a4f 100644
--- a/meson.build
+++ b/meson.build
@@ -3343,6 +3343,7 @@ if have_block
trace_events_subdirs += [
'authz',
'block',
+ 'chardev',
'io',
'nbd',
'scsi',
@@ -3354,7 +3355,6 @@ if have_system
'audio',
'backends',
'backends/tpm',
- 'chardev',
'ebpf',
'hw/9pfs',
'hw/acpi',
--
2.45.2
- [PULL 00/11] Crypto patches, Daniel P . Berrangé, 2024/07/24
- [PULL 01/11] crypto: Remove 'crypto-tls-x509-helpers.h' from crypto-tls-psk-helpers.c, Daniel P . Berrangé, 2024/07/24
- [PULL 02/11] crypto: Restrict pkix_asn1_tab[] to crypto-tls-x509-helpers.c, Daniel P . Berrangé, 2024/07/24
- [PULL 04/11] docs/devel: Add introduction to LUKS volume with detached header, Daniel P . Berrangé, 2024/07/24
- [PULL 03/11] crypto: Allow building with GnuTLS but without Libtasn1, Daniel P . Berrangé, 2024/07/24
- [PULL 07/11] meson: build chardev trace files when have_block,
Daniel P . Berrangé <=
- [PULL 09/11] crypto: drop gnutls debug logging support, Daniel P . Berrangé, 2024/07/24
- [PULL 06/11] qapi: drop unused QCryptoBlockCreateOptionsLUKS.detached-header, Daniel P . Berrangé, 2024/07/24
- [PULL 11/11] crypto: propagate errors from TLS session I/O callbacks, Daniel P . Berrangé, 2024/07/24
- [PULL 05/11] meson.build: fix libgcrypt detection on system without libgcrypt-config, Daniel P . Berrangé, 2024/07/24
- [PULL 08/11] chardev: add tracing of socket error conditions, Daniel P . Berrangé, 2024/07/24
- [PULL 10/11] crypto: push error reporting into TLS session I/O APIs, Daniel P . Berrangé, 2024/07/24
- Re: [PULL 00/11] Crypto patches, Richard Henderson, 2024/07/24