Re: [PATCH v2] chardev/char-win-stdio.c: restore old console mode

[Michael Tokarev]

24.07.2024 13:25, Marc-André Lureau wrote:
> Hi
>
> On Wed, Jul 24, 2024 at 8:48 AM Michael Tokarev <mjt@tls.msk.ru 
> <mailto:mjt@tls.msk.ru>> wrote:
>
>     22.07.2024 12:52, songziming wrote:
>      > If I use `-serial stdio` on Windows, after QEMU exits, the terminal
>      > could not handle arrow keys and tab any more. Because stdio backend
>      > on Windows sets console mode to virtual terminal input when starts,
>      > but does not restore the old mode when finalize.
>      >
>      > This small patch saves the old console mode and set it back.
>
>     Is this a stable@ material?
>
>
> It should be safe, but I don't think it deserves a stable backport: it always 
> had that behaviour before.

Well. "It was always wrong" does not mean it shouldn't be fixed, I'd say :)
In my view, a bug is a bug and it's okay to fix it even if it was here since
the day one.

Thanks,

/mjt