Re: [PATCH v4 01/17] meson: Add optional dependency on IGVM library

[Daniel P . Berrangé]

On Wed, Jul 03, 2024 at 12:05:39PM +0100, Roy Hopkins wrote:
> The IGVM library allows Independent Guest Virtual Machine files to be
> parsed and processed. IGVM files are used to configure guest memory
> layout, initial processor state and other configuration pertaining to
> secure virtual machines.
> 
> This adds the --enable-igvm configure option, enabled by default, which
> attempts to locate and link against the IGVM library via pkgconfig and
> sets CONFIG_IGVM if found.
> 
> The library is added to the system_ss target in backends/meson.build
> where the IGVM parsing will be performed by the ConfidentialGuestSupport
> object.
> 
> Signed-off-by: Roy Hopkins <roy.hopkins@suse.com>
> ---
>  meson.build                   | 8 ++++++++
>  backends/meson.build          | 3 +++
>  meson_options.txt             | 2 ++
>  scripts/meson-buildoptions.sh | 3 +++
>  4 files changed, 16 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index 54e6b09f4f..e2f7752636 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -1276,6 +1276,12 @@ if host_os == 'linux' and (have_system or have_tools)
>                         method: 'pkg-config',
>                         required: get_option('libudev'))
>  endif
> +igvm = not_found
> +if not get_option('igvm').auto() or have_system
> +  igvm = dependency('igvm',
> +                       method: 'pkg-config',
> +                       required: get_option('igvm'))

nit-picking, the indentation for these 2 lines is out of
alginment with the first line.

We probably ought to add a min version number to the
check too. IIUC, to get the namespace pollution fixes
you did, we'll want >= 0.3.0 ?

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|