Re: [PULL 26/30] target/riscv: Do not setup pmu timer if OF is disabled

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 26/30] target/riscv: Do not setup pmu timer if OF is disabled

From:	Richard Henderson
Subject:	Re: [PULL 26/30] target/riscv: Do not setup pmu timer if OF is disabled
Date:	Thu, 25 Jul 2024 07:30:25 +1000
User-agent:	Mozilla Thunderbird

On 7/25/24 05:00, Daniel Henrique Barboza wrote:

I'm not sure about which generic functions we're supposed to use in replace of
get_field/set_field, at least as far as bitops.h goes. extract64/deposit64 has a
different API (it uses start bit + length, not a mask) and it would require
a lot of RISC-V code to be adapted to this format.

Looking a little further I see that registerfields.h has the equivalent of what
we're using here: FIELD_EX64 / FIELD_SEX64. But these macros seems to be tied 
with
the abstractions used in the header, i.e. registers created with REG32/REG64 and
fields/masks created with the FIELD() macro. The header smmuv3-internal.h makes
use of them so we could use that as a base.

Hopefully Peter/Richard can correct me if I'm wrong and point to the right
direction. Thanks,


Yes, registerfields.h is the proper replacement.


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PULL 23/30] target/riscv: Enforce WARL behavior for scounteren/hcounteren, (continued)
- [PULL 23/30] target/riscv: Enforce WARL behavior for scounteren/hcounteren, Alistair Francis, 2024/07/17
- [PULL 25/30] target/riscv: More accurately model priv mode filtering., Alistair Francis, 2024/07/17
- [PULL 24/30] target/riscv: Start counters from both mhpmcounter and mcountinhibit, Alistair Francis, 2024/07/17
- [PULL 29/30] hw/riscv/virt.c: re-insert and deprecate 'riscv, delegate', Alistair Francis, 2024/07/17
- [PULL 26/30] target/riscv: Do not setup pmu timer if OF is disabled, Alistair Francis, 2024/07/17
  - Re: [PULL 26/30] target/riscv: Do not setup pmu timer if OF is disabled, Peter Maydell, 2024/07/20
    - Re: [PULL 26/30] target/riscv: Do not setup pmu timer if OF is disabled, Atish Kumar Patra, 2024/07/22
    - Re: [PULL 26/30] target/riscv: Do not setup pmu timer if OF is disabled, Alistair Francis, 2024/07/22
    - Re: [PULL 26/30] target/riscv: Do not setup pmu timer if OF is disabled, Richard Henderson, 2024/07/22
    - Re: [PULL 26/30] target/riscv: Do not setup pmu timer if OF is disabled, Daniel Henrique Barboza, 2024/07/24
    - Re: [PULL 26/30] target/riscv: Do not setup pmu timer if OF is disabled, Richard Henderson <=
    - Re: [PULL 26/30] target/riscv: Do not setup pmu timer if OF is disabled, Peter Maydell, 2024/07/25
- [PULL 28/30] target/riscv: raise an exception when CSRRS/CSRRC writes a read-only CSR, Alistair Francis, 2024/07/17
- [PULL 30/30] roms/opensbi: Update to v1.5, Alistair Francis, 2024/07/17
- [PULL 27/30] target/riscv: Expose the Smcntrpmf config, Alistair Francis, 2024/07/17
- Re: [PULL 00/30] riscv-to-apply queue, Richard Henderson, 2024/07/18

Prev by Date: [PATCH v4 11/11] pnv/xive2: Dump more END state with 'info pic'
Next by Date: Re: [PATCH v5 05/13] hw/riscv: add riscv-iommu-pci reference device
Previous by thread: Re: [PULL 26/30] target/riscv: Do not setup pmu timer if OF is disabled
Next by thread: Re: [PULL 26/30] target/riscv: Do not setup pmu timer if OF is disabled
Index(es):
- Date
- Thread