Re: [PATCH v1] target/s390x: move @deprecated-props to CpuModelExpansion Info

[Collin Walling]

On 7/26/24 5:16 PM, David Hildenbrand wrote:
> On 26.07.24 22:36, Collin Walling wrote:
>> The @deprecated-props array did not make any sense to be a member of the
>> CpuModelInfo struct, since this field would only be populated by a
>> query-cpu-model-expansion response and ignored otherwise. Move this
>> field to the CpuModelExpansionInfo struct where is makes more sense.
>>
>> References:
>>   - https://lists.gnu.org/archive/html/qemu-devel/2024-07/msg05996.html
>>   - commit eed0e8ffa38f0695c0519508f6e4f5a3297cbd67
>>
>> Signed-off-by: Collin Walling <walling@linux.ibm.com>
>> ---
>>
>> @David, the previous commit header did not align with the changes made
>> here, so I tagged this as a "v1" but added the previous conversation as
>> a reference.  I hope this is appropriate?
> 
> Thanks, I modified the "References" section and converted it to a "Fixes:".
> It's now:
> 
>      target/s390x: move @deprecated-props to CpuModelExpansion Info
>      
>      The @deprecated-props array did not make any sense to be a member of the
>      CpuModelInfo struct, since this field would only be populated by a
>      query-cpu-model-expansion response and ignored otherwise. Move this
>      field to the CpuModelExpansionInfo struct where is makes more sense.

s/is/it

>      
>      This was identified late during review [1] and we have to fix it up
>      while it's not part of an official QEMU release yet.
>      
>      [1] 
> 20240719181741.35146-1-walling@linux.ibm.com/">https://lore.kernel.org/qemu-devel/20240719181741.35146-1-walling@linux.ibm.com/
>      
>      Message-ID: <20240726203646.20279-1-walling@linux.ibm.com>
>      Fixes: eed0e8ffa38f ("target/s390x: filter deprecated properties based 
> on model expansion type")
>      Signed-off-by: Collin Walling <walling@linux.ibm.com>
>      [ david: add "Fixes", explain why fix is required now and reference to 
> v3 ]
>      Signed-off-by: David Hildenbrand <david@redhat.com>
> 
> 
> 
> Can you take a quick peek at
>       https://github.com/davidhildenbrand/qemu/tree/s390x-next
> if everything is alright?
> 

Aside from a typo (on my end), everything looks golden.  Thanks, David!

-- 
Regards,
  Collin