qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1] target/s390x: move @deprecated-props to CpuModelExpansion


From: David Hildenbrand
Subject: Re: [PATCH v1] target/s390x: move @deprecated-props to CpuModelExpansion Info
Date: Mon, 29 Jul 2024 21:48:14 +0200
User-agent: Mozilla Thunderbird



+    bitmap_zero(deprecated_feats, S390_FEAT_MAX);
+    s390_get_deprecated_features(deprecated_feats);
+
+    if (delta_changes) {
+        /*
+         * Only populate deprecated features that are a
+         * subset of the features enabled on the CPU model.
+         */
+        bitmap_and(deprecated_feats, deprecated_feats,
+                   s390_model.features, S390_FEAT_MAX);
+    }
+
+    s390_feat_bitmap_to_ascii(deprecated_feats,
+                              &expansion_info->deprecated_props, 
list_add_feat);
       return expansion_info;
   }

Eh, just a small nit above due to a typo I made.  Other than that, gave
it all another run-through just in case and everything is still good.


Fixed up, thanks!

--
Cheers,

David / dhildenb




reply via email to

[Prev in Thread] Current Thread [Next in Thread]