Re: [PATCH v10 02/21] linux-user/riscv: set priv for qemu-user and defau

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v10 02/21] linux-user/riscv: set priv for qemu-user and defau

From:	Richard Henderson
Subject:	Re: [PATCH v10 02/21] linux-user/riscv: set priv for qemu-user and defaults for *envcfg
Date:	Wed, 28 Aug 2024 21:36:48 +1000
User-agent:	Mozilla Thunderbird

On 8/28/24 10:16, Deepak Gupta wrote:

This should be handled by a CPU reset, which is still called for linux
user mode.


It is the right place for setting priv to PRV_U?
or you want me to place it elsewhere ?


Sure
for reset values of *envcfg, I can rely on `riscv_cpu_reset_hold`


Doing this in reset_hold seems correct to me.

Compare target/arm/cpu.c, arm_cpu_reset_hold:

    if (arm_feature(env, ARM_FEATURE_AARCH64)) {
        /* 64 bit CPUs always start in 64 bit mode */
        env->aarch64 = true;
#if defined(CONFIG_USER_ONLY)
        env->pstate = PSTATE_MODE_EL0t;
        /* Userspace expects access to DC ZVA, CTL_EL0 and the cache ops */
        env->cp15.sctlr_el[1] |= SCTLR_UCT | SCTLR_UCI | SCTLR_DZE;
        /* Enable all PAC keys.  */
        env->cp15.sctlr_el[1] |= (SCTLR_EnIA | SCTLR_EnIB |
                                  SCTLR_EnDA | SCTLR_EnDB);

...

That assignment to pstate is equivalent to "priv = PRV_U", and sctlr_el[] fills roughlythe same role as [ms]envcfg.

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v10 00/21] riscv support for control flow integrity extensions, Deepak Gupta, 2024/08/27
- [PATCH v10 03/21] target/riscv: Add zicfilp extension, Deepak Gupta, 2024/08/27
  - Re: [PATCH v10 03/21] target/riscv: Add zicfilp extension, Alistair Francis, 2024/08/27
- [PATCH v10 05/21] target/riscv: save and restore elp state on priv transitions, Deepak Gupta, 2024/08/27
- [PATCH v10 02/21] linux-user/riscv: set priv for qemu-user and defaults for *envcfg, Deepak Gupta, 2024/08/27
  - Re: [PATCH v10 02/21] linux-user/riscv: set priv for qemu-user and defaults for *envcfg, Alistair Francis, 2024/08/27
    - Re: [PATCH v10 02/21] linux-user/riscv: set priv for qemu-user and defaults for *envcfg, Deepak Gupta, 2024/08/27
    - Re: [PATCH v10 02/21] linux-user/riscv: set priv for qemu-user and defaults for *envcfg, Richard Henderson <=
- [PATCH v10 06/21] target/riscv: additional code information for sw check, Deepak Gupta, 2024/08/27
- [PATCH v10 01/21] target/riscv: expose *envcfg csr and priv to qemu-user as well, Deepak Gupta, 2024/08/27
  - Re: [PATCH v10 01/21] target/riscv: expose *envcfg csr and priv to qemu-user as well, Alistair Francis, 2024/08/27
- [PATCH v10 08/21] target/riscv: zicfilp `lpad` impl and branch tracking, Deepak Gupta, 2024/08/27
- [PATCH v10 04/21] target/riscv: Introduce elp state and enabling controls for zicfilp, Deepak Gupta, 2024/08/27
- [PATCH v10 11/21] target/riscv: Add zicfiss extension, Deepak Gupta, 2024/08/27
  - Re: [PATCH v10 11/21] target/riscv: Add zicfiss extension, Alistair Francis, 2024/08/27
- [PATCH v10 09/21] disas/riscv: enable `lpad` disassembly, Deepak Gupta, 2024/08/27
- [PATCH v10 10/21] target/riscv: Expose zicfilp extension as a cpu property, Deepak Gupta, 2024/08/27
  - Re: [PATCH v10 10/21] target/riscv: Expose zicfilp extension as a cpu property, Alistair Francis, 2024/08/27

Prev by Date: Re: [PULL 17/20] target/arm: Do memory type alignment check when translation disabled
Next by Date: Re: [PATCH 2/2] hw/cxl/cxl_event: Fix interrupt triggering for dynamic capacity events grouped via More flag
Previous by thread: Re: [PATCH v10 02/21] linux-user/riscv: set priv for qemu-user and defaults for *envcfg
Next by thread: [PATCH v10 06/21] target/riscv: additional code information for sw check
Index(es):
- Date
- Thread