[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 48/61] hw/sensor/tmp105: Lower 4 bit of limit registers are alw
From: |
Philippe Mathieu-Daudé |
Subject: |
[PULL v2 48/61] hw/sensor/tmp105: Lower 4 bit of limit registers are always 0 |
Date: |
Thu, 12 Sep 2024 08:52:19 +0200 |
From: Guenter Roeck <linux@roeck-us.net>
Per datasheet, "HIGH AND LOW LIMIT REGISTERS", the lower 4 bit
of the limit registers are unused and always report 0.
The lower 4 bit should not be used for temperature comparisons,
so mask the unused bits before storing the limits.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20240906154911.86803-6-philmd@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/sensor/tmp105.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/sensor/tmp105.c b/hw/sensor/tmp105.c
index f5101af919..9d7b911f59 100644
--- a/hw/sensor/tmp105.c
+++ b/hw/sensor/tmp105.c
@@ -171,7 +171,7 @@ static void tmp105_write(TMP105State *s)
case TMP105_REG_T_HIGH:
if (s->len >= 3) {
s->limit[s->pointer & 1] = (int16_t)
- ((((uint16_t) s->buf[0]) << 8) | s->buf[1]);
+ ((((uint16_t) s->buf[0]) << 8) | (s->buf[1] & 0xf0));
}
tmp105_alarm_update(s, false);
break;
--
2.45.2
- [PULL v2 00/61] Misc HW & UI patches for 2024-09-12, Philippe Mathieu-Daudé, 2024/09/12
- [PULL v2 44/61] hw/sensor/tmp105: Coding style fixes, Philippe Mathieu-Daudé, 2024/09/12
- [PULL v2 45/61] hw/sensor/tmp105: Use registerfields API, Philippe Mathieu-Daudé, 2024/09/12
- [PULL v2 46/61] hw/sensor/tmp105: Pass 'oneshot' argument to tmp105_alarm_update(), Philippe Mathieu-Daudé, 2024/09/12
- [PULL v2 47/61] hw/sensor/tmp105: OS (one-shot) bit in config register always returns 0, Philippe Mathieu-Daudé, 2024/09/12
- [PULL v2 48/61] hw/sensor/tmp105: Lower 4 bit of limit registers are always 0,
Philippe Mathieu-Daudé <=
- [PULL v2 51/61] hw/char: replace assert(0) with g_assert_not_reached(), Philippe Mathieu-Daudé, 2024/09/12
- [PULL v2 52/61] hw/core: replace assert(0) with g_assert_not_reached(), Philippe Mathieu-Daudé, 2024/09/12
- [PULL v2 53/61] hw/watchdog: replace assert(0) with g_assert_not_reached(), Philippe Mathieu-Daudé, 2024/09/12
- [PULL v2 55/61] hw/misc: remove break after g_assert_not_reached(), Philippe Mathieu-Daudé, 2024/09/12
- [PULL v2 54/61] hw/gpio: remove break after g_assert_not_reached(), Philippe Mathieu-Daudé, 2024/09/12
- [PULL v2 56/61] hw/pci-host: remove break after g_assert_not_reached(), Philippe Mathieu-Daudé, 2024/09/12
- [PULL v2 57/61] system: replace assert(0) with g_assert_not_reached(), Philippe Mathieu-Daudé, 2024/09/12
- [PULL v2 61/61] ui: remove break after g_assert_not_reached(), Philippe Mathieu-Daudé, 2024/09/12
- Re: [PULL v2 00/61] Misc HW & UI patches for 2024-09-12, Peter Maydell, 2024/09/13