qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 for-10.0 11/54] target/x86: Set FloatInfZeroNaNRule explic


From: Richard Henderson
Subject: Re: [PATCH v2 for-10.0 11/54] target/x86: Set FloatInfZeroNaNRule explicitly
Date: Mon, 2 Dec 2024 11:06:54 -0600
User-agent: Mozilla Thunderbird

On 12/2/24 07:13, Peter Maydell wrote:
Set the FloatInfZeroNaNRule explicitly for the x86 target.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
v1->v2: Update the comment to give the info from the x86
spec rather than a TODO comment saying we need to check it...
---
  target/i386/tcg/fpu_helper.c   | 7 +++++++
  fpu/softfloat-specialize.c.inc | 2 +-
  2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/target/i386/tcg/fpu_helper.c b/target/i386/tcg/fpu_helper.c
index 53b49bb2977..a98b4f67ff0 100644
--- a/target/i386/tcg/fpu_helper.c
+++ b/target/i386/tcg/fpu_helper.c
@@ -173,6 +173,13 @@ void cpu_init_fp_statuses(CPUX86State *env)
       */
      set_float_2nan_prop_rule(float_2nan_prop_x87, &env->mmx_status);
      set_float_2nan_prop_rule(float_2nan_prop_x87, &env->sse_status);
+    /*
+     * Only SSE has multiply-add instructions. In the SDM Section 14.5.2
+     * "Fused-Multiply-ADD (FMA) Numeric Behavior" the NaN handling is
+     * specified -- for 0 * inf + NaN the input NaN is selected, and if
+     * there are multiple input NaNs athey are selected in the order a, b, c.

"athey"

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]