qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/1] MAINTAINERS: update email addr for Brian Cain


From: Brian Cain
Subject: Re: [PATCH 1/1] MAINTAINERS: update email addr for Brian Cain
Date: Tue, 3 Dec 2024 09:01:56 -0600
User-agent: Mozilla Thunderbird


On 12/3/2024 8:53 AM, Philippe Mathieu-Daudé wrote:
On 3/12/24 15:31, Peter Maydell wrote:
On Tue, 3 Dec 2024 at 14:23, Brian Cain <brian.cain@oss.qualcomm.com> wrote:


On 12/2/2024 2:43 PM, Philippe Mathieu-Daudé wrote:
On 23/11/24 17:46, Brian Cain wrote:
From: Brian Cain <brian.cain@oss.qualcomm.com>

Also: add mapping for "quic_bcain@quicinc.com" which was ~briefly
used for some replies to mailing list traffic.

Signed-off-by: Brian Cain <bcain@quicinc.com>
Signed-off-by: Brian Cain <brian.cain@oss.qualcomm.com>
---
   .mailmap    | 2 ++
   MAINTAINERS | 2 +-
   2 files changed, 3 insertions(+), 1 deletion(-)

Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Forgive my ignorance here -- this T-b is - stronger than a R-b? or
weaker than a R-b?  Or wholly orthogonal to R-b?

They mean different things -- T-b says "I tested this patch
and it works for me", and R-b says "I looked at the code
change and think it's a good change with no bugs".

T-b is a slightly odd thing to have on a MAINTAINERS
change, though I'm guessing Philippe might mean they tested
that the .mailmap change affected the commits the way it
was supposed to.

I tested oss.qualcomm.com is a valid MX and we can send
emails to it.

Then I looked at the recent github changes from quicinc
around oss.qualcomm.com, and that this email was posted
from your bcain@quicinc.com address. For that I could have
used a R-b tag I guess 🤷

Ok, tyvm Peter and Phil for the explanation :)



Should I still seek a R-b before making a pull request with this change?

Philippe put this into his pullreq he just sent out, so you
don't need to do anything more on your end.

Yes, sorry I forgot to notify you here first.

Thanks for picking it up ;)



thanks
-- PMM




reply via email to

[Prev in Thread] Current Thread [Next in Thread]