Re: [RFC PATCH v1 08/43] include/helper-to-tcg: Introduce annotate.h

[Anton Johansson]

On 25/11/24, Philippe Mathieu-Daudé wrote:
> On 22/11/24 19:12, Richard Henderson wrote:
> > On 11/20/24 19:49, Anton Johansson wrote:
> > > Wrap __attribute__((annotate(str))) in a macro for convenient
> > > function annotations.  Will be used in future commits to tag functions
> > > for translation by helper-to-tcg, and to specify which helper function
> > > arguments correspond to immediate or vector values.
> > > 
> > > Signed-off-by: Anton Johansson <anjo@rev.ng>
> > > ---
> > >   include/helper-to-tcg/annotate.h | 28 ++++++++++++++++++++++++++++
> > >   1 file changed, 28 insertions(+)
> > >   create mode 100644 include/helper-to-tcg/annotate.h
> > 
> > Is this really specific to helper-to-tcg, or might it be used for
> > something else in the future?  In other words, does it belong in
> > include/qemu/compiler.h?
> 
> We already have there QEMU_ANNOTATE() since end of 2022
> (use in commit cbdbc47cee, QEMU macro in d79b9202e4).

Oh this is very nice! I'll use QEMU_ANNOTATE() then! Thanks:)

//Anton