Re: [RFC PATCH v1 37/43] target/hexagon: Make HVX vector args. restrict *

[Brian Cain]

On 12/3/2024 12:57 PM, Anton Johansson via wrote:
> On 25/11/24, Paolo Bonzini wrote:
> > On 11/25/24 12:36, Philippe Mathieu-Daudé wrote:
> > > > +#define QeV      (*(MMQReg * restrict)(QeV_void))
> > > > +#define QdV      (*(MMQReg * restrict)(QdV_void))
> > > > +#define QsV      (*(MMQReg * restrict)(QsV_void))
> > > > +#define QtV      (*(MMQReg * restrict)(QtV_void))
> > > > +#define QuV      (*(MMQReg * restrict)(QuV_void))
> > > > +#define QvV      (*(MMQReg * restrict)(QvV_void))
> > > > +#define QxV      (*(MMQReg * restrict)(QxV_void))
> > > >    #endif
> > > Maybe we need to fix scripts/checkpatch.pl along?
> > >
> > > ERROR: "foo * bar" should be "foo *bar"
> > > #31: FILE: target/hexagon/mmvec/macros.h:26:
> > > +#define VdV      (*(MMVector * restrict)(VdV_void))
> > >
> > > ERROR: "foo * bar" should be "foo *bar"
> > > #32: FILE: target/hexagon/mmvec/macros.h:27:
> > > +#define VsV      (*(MMVector * restrict)(VsV_void))
> > >
> > > ERROR: "foo * bar" should be "foo *bar"
> > > #33: FILE: target/hexagon/mmvec/macros.h:28:
> > > +#define VuV      (*(MMVector * restrict)(VuV_void))
> > I think checkpatch.pl has a point here. :)
> I'll switch to `*restrict`!:)


With this change to fix checkpatch,

Reviewed-by: Brian Cain <brian.cain@oss.qualcomm.com>


> //Anton