Re: [PATCH v3 7/7] aspeed/soc: Support eMMC for AST2700

[Cédric Le Goater]

On 12/4/24 09:05, Jamin Lin wrote:
> Add SDHCI model for AST2700 eMMC support. The eMMC controller only support 1
> slot and registers base address is start at 0x1209_0000 and its interrupt is
> connected to GICINT 15.
>
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/arm/aspeed_ast27x0.c | 15 +++++++++++++++
>   1 file changed, 15 insertions(+)
>
> diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c
> index baddd35ecf..23571584b2 100644
> --- a/hw/arm/aspeed_ast27x0.c
> +++ b/hw/arm/aspeed_ast27x0.c
> @@ -391,6 +391,12 @@ static void aspeed_soc_ast2700_init(Object *obj)
>       /* Init sd card slot class here so that they're under the correct parent 
> */
>       object_initialize_child(obj, "sd-controller.sdhci",
>                               &s->sdhci.slots[0], TYPE_SYSBUS_SDHCI);
> +
> +    object_initialize_child(obj, "emmc-controller", &s->emmc, typename);
> +    object_property_set_int(OBJECT(&s->emmc), "num-slots", 1, &error_abort);
> +
> +    object_initialize_child(obj, "emmc-controller.sdhci", &s->emmc.slots[0],
> +                            TYPE_SYSBUS_SDHCI);
>   }
>   
>   /*
> @@ -701,6 +707,15 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, 
> Error **errp)
>       sysbus_connect_irq(SYS_BUS_DEVICE(&s->sdhci), 0,
>                          aspeed_soc_get_irq(s, ASPEED_DEV_SDHCI));
>   
> +    /* eMMC */
> +    if (!sysbus_realize(SYS_BUS_DEVICE(&s->emmc), errp)) {
> +        return;
> +    }
> +    aspeed_mmio_map(s, SYS_BUS_DEVICE(&s->emmc), 0,
> +                    sc->memmap[ASPEED_DEV_EMMC]);
> +    sysbus_connect_irq(SYS_BUS_DEVICE(&s->emmc), 0,
> +                       aspeed_soc_get_irq(s, ASPEED_DEV_EMMC));
> +
>       create_unimplemented_device("ast2700.dpmcu", 0x11000000, 0x40000);
>       create_unimplemented_device("ast2700.iomem0", 0x12000000, 0x01000000);
>       create_unimplemented_device("ast2700.iomem1", 0x14000000, 0x01000000);