Re: [PATCH V4 14/19] migration: cpr-transfer mode

[Steven Sistare]

On 12/2/2024 8:20 AM, Steve Sistare wrote:
[...]
> +
> +    /*
> +     * If qmp_migrate_finish has not been called, then there is no path that
> +     * will complete the cancellation.  Do it now.
> +     */
> +    if (setup && !s->to_dst_file) {
> +        migrate_set_state(&s->state, s->state, MIGRATION_STATUS_CANCELLED);
> +        cpr_state_close();
> +        migrate_hup_delete(s);
> +        vm_resume(s->vm_old_state);
> +    }

I forgot to make changes here as we discussed in
  
https://lore.kernel.org/qemu-devel/2dc614cb-8754-423f-8c31-e5425075af92@oracle.com/

I will move vm_resume to the patch "stop vm earlier for cpr" in a later series, 
and
verify the current state:

+    if (setup && !s->to_dst_file) {
+        migrate_set_state(&s->state, MIGRATION_STATUS_CANCELLING, 
MIGRATION_STATUS_CANCELLED);
+        cpr_state_close();
+        migrate_hup_delete(s);
+    }

- Steve