Re: [PATCH V4 04/19] machine: aux-ram-share option

[Peter Xu]

On Thu, Dec 12, 2024 at 03:38:07PM -0500, Steven Sistare wrote:
> On 12/9/2024 2:54 PM, Peter Xu wrote:
> > On Mon, Dec 02, 2024 at 05:19:56AM -0800, Steve Sistare wrote:
> > > diff --git a/system/physmem.c b/system/physmem.c
> > > index 36f0811..0bcb2cc 100644
> > > --- a/system/physmem.c
> > > +++ b/system/physmem.c
> > > @@ -2164,6 +2164,9 @@ RAMBlock *qemu_ram_alloc_internal(ram_addr_t size, 
> > > ram_addr_t max_size,
> > >       new_block->flags = ram_flags;
> > >       if (!host && !xen_enabled()) {
> > > +        if (!share_flags && current_machine->aux_ram_share) {
> > > +            new_block->flags |= RAM_SHARED;
> > > +        }
> > 
> > Just to mention that if you agree with what I said in patch 2, here it will
> > need some trivial rebase change.  IOW, IMO we shouldn't special case xen
> > either here, so it should also apply to xen if one chose to, changing aux
> > alloc to RAM_SHARED.
> 
> OK.
> 
> So, if this only requires a trivial change, do I get your RB?

Yes please.

-- 
Peter Xu