[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 11/13] rust/timer/hpet: add basic HPET timer & state
From: |
Paolo Bonzini |
Subject: |
Re: [RFC 11/13] rust/timer/hpet: add basic HPET timer & state |
Date: |
Thu, 5 Dec 2024 22:20:47 +0100 |
On Thu, Dec 5, 2024 at 9:23 PM Paolo Bonzini <pbonzini@redhat.com> wrote:
> > + /// Instance id (HPET timer block ID).
> > + hpet_id: BqlCell<usize>,
> > +}
> > +
> Like flags this does not need to be a cell.
Well, this *should not* need to be a cell (ideally fw_cfg would call a
C function to generate FW_CFG_HPET) but it can't be done yet, so you
can keep it. flags need not be a BqlCell though.
Paolo
- Re: [RFC 09/13] i386/fw_cfg: move hpet_cfg definition to hpet.c, (continued)
- Re: [RFC 09/13] i386/fw_cfg: move hpet_cfg definition to hpet.c, Zhao Liu, 2024/12/05
- Re: [RFC 09/13] i386/fw_cfg: move hpet_cfg definition to hpet.c, Philippe Mathieu-Daudé, 2024/12/05
- Re: [RFC 09/13] i386/fw_cfg: move hpet_cfg definition to hpet.c, Paolo Bonzini, 2024/12/05
- Re: [RFC 09/13] i386/fw_cfg: move hpet_cfg definition to hpet.c, Philippe Mathieu-Daudé, 2024/12/07
- Re: [RFC 09/13] i386/fw_cfg: move hpet_cfg definition to hpet.c, Zhao Liu, 2024/12/07
Re: [RFC 09/13] i386/fw_cfg: move hpet_cfg definition to hpet.c, Paolo Bonzini, 2024/12/05
[RFC 10/13] rust/timer/hpet: define hpet_fw_cfg, Zhao Liu, 2024/12/05
[RFC 11/13] rust/timer/hpet: add basic HPET timer & state, Zhao Liu, 2024/12/05
[RFC 12/13] rust/timer/hpet: add qdev APIs support, Zhao Liu, 2024/12/05
[RFC 13/13] i386: enable rust hpet for pc when rust is enabled, Zhao Liu, 2024/12/05
Re: [RFC 00/13] rust: Reinvent the wheel for HPET timer in Rust, Zhao Liu, 2024/12/05
Re: [RFC 00/13] rust: Reinvent the wheel for HPET timer in Rust, Paolo Bonzini, 2024/12/05