Re: [PATCH 24/67] target/arm: Pass fpstatus to vfp_sqrt*

[Philippe Mathieu-Daudé]

On 1/12/24 16:05, Richard Henderson wrote:
> Pass fpstatus not env, like most other fp helpers.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   target/arm/helper.h            |  6 +++---
>   target/arm/tcg/translate-a64.c | 15 +++++++--------
>   target/arm/tcg/translate-vfp.c |  6 +++---
>   target/arm/vfp_helper.c        | 12 ++++++------
>   4 files changed, 19 insertions(+), 20 deletions(-)


> @@ -10403,6 +10401,7 @@ static void disas_simd_two_reg_misc(DisasContext *s, 
> uint32_t insn)
>               handle_2misc_fcmp_zero(s, opcode, false, u, is_q, size, rn, rd);
>               return;
>           case 0x7f: /* FSQRT */
> +            need_fpstatus = true;

Should this change be in a different patch?

>               if (size == 3 && !is_q) {
>                   unallocated_encoding(s);
>                   return;
>   }