[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 13/31] acpi/ghes: better name the offset of the hardware error fi
From: |
Mauro Carvalho Chehab |
Subject: |
[PATCH 13/31] acpi/ghes: better name the offset of the hardware error firmware |
Date: |
Fri, 6 Dec 2024 18:12:35 +0100 |
The etc/hardware_errors fw_cfg file is where the HEST error
source structures store registers pointed by Generic Address
Structures, as defined at:
https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#generic-error-data-entry
and
https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#generic-hardware-error-source-version-2-ghesv2-structure
As the name of the firmware file is hardware_errors, better
name the variable where the offset pointing to it will be stored
from ghes_error_le to hw_error_le.
No functional changes.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
---
hw/acpi/generic_event_device.c | 4 ++--
hw/acpi/ghes.c | 4 ++--
include/hw/acpi/ghes.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
index 663d9cb09380..17baf36132a8 100644
--- a/hw/acpi/generic_event_device.c
+++ b/hw/acpi/generic_event_device.c
@@ -364,7 +364,7 @@ static const VMStateDescription vmstate_ghes = {
.version_id = 1,
.minimum_version_id = 1,
.fields = (const VMStateField[]) {
- VMSTATE_UINT64(ghes_addr_le, AcpiGhesState),
+ VMSTATE_UINT64(hw_error_le, AcpiGhesState),
VMSTATE_END_OF_LIST()
},
};
@@ -372,7 +372,7 @@ static const VMStateDescription vmstate_ghes = {
static bool ghes_needed(void *opaque)
{
AcpiGedState *s = opaque;
- return s->ghes_state.ghes_addr_le;
+ return s->ghes_state.hw_error_le;
}
static const VMStateDescription vmstate_ghes_state = {
diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
index 52c2b69d3664..90d76b9c2d8c 100644
--- a/hw/acpi/ghes.c
+++ b/hw/acpi/ghes.c
@@ -359,7 +359,7 @@ void acpi_ghes_add_fw_cfg(AcpiGhesState *ags, FWCfgState *s,
/* Create a read-write fw_cfg file for Address */
fw_cfg_add_file_callback(s, ACPI_HW_ERROR_ADDR_FW_CFG_FILE, NULL, NULL,
- NULL, &(ags->ghes_addr_le), sizeof(ags->ghes_addr_le), false);
+ NULL, &(ags->hw_error_le), sizeof(ags->hw_error_le), false);
ags->present = true;
}
@@ -385,7 +385,7 @@ void ghes_record_cper_errors(const void *cper, size_t len,
}
ags = &acpi_ged_state->ghes_state;
- start_addr = le64_to_cpu(ags->ghes_addr_le);
+ start_addr = le64_to_cpu(ags->hw_error_le);
start_addr += source_id * sizeof(uint64_t);
diff --git a/include/hw/acpi/ghes.h b/include/hw/acpi/ghes.h
index 21666a4bcc8b..39619a2457cb 100644
--- a/include/hw/acpi/ghes.h
+++ b/include/hw/acpi/ghes.h
@@ -65,7 +65,7 @@ enum {
};
typedef struct AcpiGhesState {
- uint64_t ghes_addr_le;
+ uint64_t hw_error_le;
bool present; /* True if GHES is present at all on this board */
} AcpiGhesState;
--
2.47.1
- [PATCH 23/31] scripts/ghes_inject: add a script to generate GHES error inject, (continued)
- [PATCH 21/31] arm/virt: Wire up a GED error device for ACPI / GHES, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 18/31] acpi/generic_event_device: add logic to detect if HEST addr is available, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 29/31] HACK: use GPIO as source ID for virt-9.1 machines, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 20/31] acpi/generic_event_device: add an APEI error device, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 16/31] acpi/ghes: Use HEST table offsets when preparing GHES records, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 13/31] acpi/ghes: better name the offset of the hardware error firmware,
Mauro Carvalho Chehab <=
- [PATCH 14/31] acpi/ghes: Prepare to support multiple sources on ghes, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 24/31] target/arm: add an experimental mpidr arm cpu property object, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 09/31] acpi/ghes: make the GHES record generation more generic, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 26/31] acpi/ghes: move offset calculus to a separate function, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 22/31] qapi/acpi-hest: add an interface to do generic CPER error injection, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 30/31] docs: acpi_hest_ghes: fix documentation for CPER size, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 25/31] scripts/arm_processor_error.py: retrieve mpidr if not filled, Mauro Carvalho Chehab, 2024/12/06
- [PATCH 28/31] acpi/ghes: Change ghes fill logic to work with only one source, Mauro Carvalho Chehab, 2024/12/06
- Re: [PATCH 00/31] Prepare GHES driver to support error injection, Markus Armbruster, 2024/12/07