Re: [RFC 06/13] rust: add bindings for memattrs

[Paolo Bonzini]

Il sab 7 dic 2024, 10:21 Philippe Mathieu-Daudé <philmd@linaro.org> ha scritto:

>> is still decently packed and simplifies things a lot.
>
> The old struct is 4 bytes, and the new one is 8 bytes. We do
> a lot of directly passing 'struct MemTxAttrs' arguments around
> as arguments to functions (i.e. not passing pointers to them),
> so increasing it in size is not completely free.

Should we add a check to not pass 8 bytes?

   QEMU_BUILD_BUG_ON(sizeof(MemTxAttrs) != sizeof(uint64_t));

Yes, why not. 

Paolo