[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/72] target/mips: Set FloatInfZeroNaNRule explicitly
From: |
Peter Maydell |
Subject: |
[PULL 13/72] target/mips: Set FloatInfZeroNaNRule explicitly |
Date: |
Wed, 11 Dec 2024 16:19:05 +0000 |
Set the FloatInfZeroNaNRule explicitly for the MIPS target,
so we can remove the ifdef from pickNaNMulAdd().
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20241202131347.498124-9-peter.maydell@linaro.org
---
target/mips/fpu_helper.h | 9 +++++++++
target/mips/msa.c | 4 ++++
fpu/softfloat-specialize.c.inc | 16 +---------------
3 files changed, 14 insertions(+), 15 deletions(-)
diff --git a/target/mips/fpu_helper.h b/target/mips/fpu_helper.h
index 7c3c7897b45..be66f2f813a 100644
--- a/target/mips/fpu_helper.h
+++ b/target/mips/fpu_helper.h
@@ -28,6 +28,7 @@ static inline void restore_flush_mode(CPUMIPSState *env)
static inline void restore_snan_bit_mode(CPUMIPSState *env)
{
bool nan2008 = env->active_fpu.fcr31 & (1 << FCR31_NAN2008);
+ FloatInfZeroNaNRule izn_rule;
/*
* With nan2008, SNaNs are silenced in the usual way.
@@ -35,6 +36,14 @@ static inline void restore_snan_bit_mode(CPUMIPSState *env)
*/
set_snan_bit_is_one(!nan2008, &env->active_fpu.fp_status);
set_default_nan_mode(!nan2008, &env->active_fpu.fp_status);
+ /*
+ * For MIPS systems that conform to IEEE754-1985, the (inf,zero,nan)
+ * case sets InvalidOp and returns the default NaN.
+ * For MIPS systems that conform to IEEE754-2008, the (inf,zero,nan)
+ * case sets InvalidOp and returns the input value 'c'.
+ */
+ izn_rule = nan2008 ? float_infzeronan_dnan_never :
float_infzeronan_dnan_always;
+ set_float_infzeronan_rule(izn_rule, &env->active_fpu.fp_status);
}
static inline void restore_fp_status(CPUMIPSState *env)
diff --git a/target/mips/msa.c b/target/mips/msa.c
index 9dffc428f5c..cc152db27f9 100644
--- a/target/mips/msa.c
+++ b/target/mips/msa.c
@@ -74,4 +74,8 @@ void msa_reset(CPUMIPSState *env)
/* set proper signanling bit meaning ("1" means "quiet") */
set_snan_bit_is_one(0, &env->active_tc.msa_fp_status);
+
+ /* Inf * 0 + NaN returns the input NaN */
+ set_float_infzeronan_rule(float_infzeronan_dnan_never,
+ &env->active_tc.msa_fp_status);
}
diff --git a/fpu/softfloat-specialize.c.inc b/fpu/softfloat-specialize.c.inc
index 2023b2bd632..db9a466e05b 100644
--- a/fpu/softfloat-specialize.c.inc
+++ b/fpu/softfloat-specialize.c.inc
@@ -489,21 +489,7 @@ static int pickNaNMulAdd(FloatClass a_cls, FloatClass
b_cls, FloatClass c_cls,
/*
* Temporarily fall back to ifdef ladder
*/
-#if defined(TARGET_MIPS)
- if (snan_bit_is_one(status)) {
- /*
- * For MIPS systems that conform to IEEE754-1985, the
(inf,zero,nan)
- * case sets InvalidOp and returns the default NaN
- */
- rule = float_infzeronan_dnan_always;
- } else {
- /*
- * For MIPS systems that conform to IEEE754-2008, the
(inf,zero,nan)
- * case sets InvalidOp and returns the input value 'c'
- */
- rule = float_infzeronan_dnan_never;
- }
-#elif defined(TARGET_SPARC) || \
+#if defined(TARGET_SPARC) || \
defined(TARGET_XTENSA) || defined(TARGET_HPPA) || \
defined(TARGET_I386) || defined(TARGET_LOONGARCH)
/*
--
2.34.1
- [PULL 04/72] hw/net/lan9118_phy: Reuse MII constants, (continued)
- [PULL 04/72] hw/net/lan9118_phy: Reuse MII constants, Peter Maydell, 2024/12/11
- [PULL 05/72] hw/net/lan9118_phy: Add missing 100 mbps full duplex advertisement, Peter Maydell, 2024/12/11
- [PULL 06/72] fpu: handle raising Invalid for infzero in pick_nan_muladd, Peter Maydell, 2024/12/11
- [PULL 02/72] hw/net/lan9118_phy: Reuse in imx_fec and consolidate implementations, Peter Maydell, 2024/12/11
- [PULL 07/72] fpu: Check for default_nan_mode before calling pickNaNMulAdd, Peter Maydell, 2024/12/11
- [PULL 08/72] softfloat: Allow runtime choice of inf * 0 + NaN result, Peter Maydell, 2024/12/11
- [PULL 09/72] tests/fp: Explicitly set inf-zero-nan rule, Peter Maydell, 2024/12/11
- [PULL 10/72] target/arm: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 11/72] target/s390: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 12/72] target/ppc: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 13/72] target/mips: Set FloatInfZeroNaNRule explicitly,
Peter Maydell <=
- [PULL 14/72] target/sparc: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 15/72] target/xtensa: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 16/72] target/x86: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 19/72] softfloat: Pass have_snan to pickNaNMulAdd, Peter Maydell, 2024/12/11
- [PULL 17/72] target/loongarch: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 18/72] target/hppa: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 20/72] softfloat: Allow runtime choice of NaN propagation for muladd, Peter Maydell, 2024/12/11
- [PULL 23/72] target/loongarch: Set Float3NaNPropRule explicitly, Peter Maydell, 2024/12/11
- [PULL 24/72] target/ppc: Set Float3NaNPropRule explicitly, Peter Maydell, 2024/12/11
- [PULL 22/72] target/arm: Set Float3NaNPropRule explicitly, Peter Maydell, 2024/12/11