[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 16/72] target/x86: Set FloatInfZeroNaNRule explicitly
From: |
Peter Maydell |
Subject: |
[PULL 16/72] target/x86: Set FloatInfZeroNaNRule explicitly |
Date: |
Wed, 11 Dec 2024 16:19:08 +0000 |
Set the FloatInfZeroNaNRule explicitly for the x86 target.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20241202131347.498124-12-peter.maydell@linaro.org
---
target/i386/tcg/fpu_helper.c | 7 +++++++
fpu/softfloat-specialize.c.inc | 2 +-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/target/i386/tcg/fpu_helper.c b/target/i386/tcg/fpu_helper.c
index 53b49bb2977..3295753e075 100644
--- a/target/i386/tcg/fpu_helper.c
+++ b/target/i386/tcg/fpu_helper.c
@@ -173,6 +173,13 @@ void cpu_init_fp_statuses(CPUX86State *env)
*/
set_float_2nan_prop_rule(float_2nan_prop_x87, &env->mmx_status);
set_float_2nan_prop_rule(float_2nan_prop_x87, &env->sse_status);
+ /*
+ * Only SSE has multiply-add instructions. In the SDM Section 14.5.2
+ * "Fused-Multiply-ADD (FMA) Numeric Behavior" the NaN handling is
+ * specified -- for 0 * inf + NaN the input NaN is selected, and if
+ * there are multiple input NaNs they are selected in the order a, b, c.
+ */
+ set_float_infzeronan_rule(float_infzeronan_dnan_never, &env->sse_status);
}
static inline uint8_t save_exception_flags(CPUX86State *env)
diff --git a/fpu/softfloat-specialize.c.inc b/fpu/softfloat-specialize.c.inc
index 3062d19402d..ad4f7096d09 100644
--- a/fpu/softfloat-specialize.c.inc
+++ b/fpu/softfloat-specialize.c.inc
@@ -490,7 +490,7 @@ static int pickNaNMulAdd(FloatClass a_cls, FloatClass
b_cls, FloatClass c_cls,
* Temporarily fall back to ifdef ladder
*/
#if defined(TARGET_HPPA) || \
- defined(TARGET_I386) || defined(TARGET_LOONGARCH)
+ defined(TARGET_LOONGARCH)
/*
* For LoongArch systems that conform to IEEE754-2008, the
(inf,zero,nan)
* case sets InvalidOp and returns the input value 'c'
--
2.34.1
- [PULL 02/72] hw/net/lan9118_phy: Reuse in imx_fec and consolidate implementations, (continued)
- [PULL 02/72] hw/net/lan9118_phy: Reuse in imx_fec and consolidate implementations, Peter Maydell, 2024/12/11
- [PULL 07/72] fpu: Check for default_nan_mode before calling pickNaNMulAdd, Peter Maydell, 2024/12/11
- [PULL 08/72] softfloat: Allow runtime choice of inf * 0 + NaN result, Peter Maydell, 2024/12/11
- [PULL 09/72] tests/fp: Explicitly set inf-zero-nan rule, Peter Maydell, 2024/12/11
- [PULL 10/72] target/arm: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 11/72] target/s390: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 12/72] target/ppc: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 13/72] target/mips: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 14/72] target/sparc: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 15/72] target/xtensa: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 16/72] target/x86: Set FloatInfZeroNaNRule explicitly,
Peter Maydell <=
- [PULL 19/72] softfloat: Pass have_snan to pickNaNMulAdd, Peter Maydell, 2024/12/11
- [PULL 17/72] target/loongarch: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 18/72] target/hppa: Set FloatInfZeroNaNRule explicitly, Peter Maydell, 2024/12/11
- [PULL 20/72] softfloat: Allow runtime choice of NaN propagation for muladd, Peter Maydell, 2024/12/11
- [PULL 23/72] target/loongarch: Set Float3NaNPropRule explicitly, Peter Maydell, 2024/12/11
- [PULL 24/72] target/ppc: Set Float3NaNPropRule explicitly, Peter Maydell, 2024/12/11
- [PULL 22/72] target/arm: Set Float3NaNPropRule explicitly, Peter Maydell, 2024/12/11
- [PULL 21/72] tests/fp: Explicitly set 3-NaN propagation rule, Peter Maydell, 2024/12/11
- [PULL 27/72] target/mips: Set Float3NaNPropRule explicitly, Peter Maydell, 2024/12/11
- [PULL 28/72] target/xtensa: Set Float3NaNPropRule explicitly, Peter Maydell, 2024/12/11