Re: [PATCH v2 23/31] tests/functional: convert tests to new archive_extract helper

[Thomas Huth]

On 11/12/2024 18.26, Daniel P. Berrangé wrote:
> Replace use of utils.archive_extract and extract_from_deb with the
> new archive_extract helper.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
...
> diff --git a/tests/functional/qemu_test/linuxkernel.py 
> b/tests/functional/qemu_test/linuxkernel.py
> index 8f2810f3af..155855541f 100644
> --- a/tests/functional/qemu_test/linuxkernel.py
> +++ b/tests/functional/qemu_test/linuxkernel.py
> @@ -3,11 +3,9 @@
>   # This work is licensed under the terms of the GNU GPL, version 2 or
>   # later.  See the COPYING file in the top-level directory.
>   
> -import os
> -
>   from .testcase import QemuSystemTest
>   from .cmd import wait_for_console_pattern
> -from .archive import deb_extract
> +
>   
>   
>   class LinuxKernelTest(QemuSystemTest):

Cosmetical nit: Two empty lines should be enough, no reason to add a third one.

Apart from that:
Reviewed-by: Thomas Huth <thuth@redhat.com>