Re: [PATCH v2 28/31] tests/functional: replace 'run

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 28/31] tests/functional: replace 'run_cmd' with subprocess

From:	Thomas Huth
Subject:	Re: [PATCH v2 28/31] tests/functional: replace 'run_cmd' with subprocess helpers
Date:	Thu, 12 Dec 2024 12:11:54 +0100
User-agent:	Mozilla Thunderbird

On 11/12/2024 18.26, Daniel P. Berrangé wrote:

The 'run_cmd' helper is re-implementing a convenient helper that
already exists in the form of the 'run' and 'check_call' methods
provided by 'subprocess'.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---


Reviewed-by: Thomas Huth <thuth@redhat.com>

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 24/31] tests/functional: add a generalized uncompress helper, (continued)
- [PATCH v2 24/31] tests/functional: add a generalized uncompress helper, Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 24/31] tests/functional: add a generalized uncompress helper, Thomas Huth, 2024/12/12
- [PATCH v2 25/31] tests/functional: add 'uncompress' to QemuBaseTest, Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 25/31] tests/functional: add 'uncompress' to QemuBaseTest, Thomas Huth, 2024/12/12
- [PATCH v2 23/31] tests/functional: convert tests to new archive_extract helper, Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 23/31] tests/functional: convert tests to new archive_extract helper, Thomas Huth, 2024/12/12
    - Re: [PATCH v2 23/31] tests/functional: convert tests to new archive_extract helper, Daniel P . Berrangé, 2024/12/12
- [PATCH v2 26/31] tests/functional: convert tests to new uncompress helper, Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 26/31] tests/functional: convert tests to new uncompress helper, Thomas Huth, 2024/12/12
- [PATCH v2 28/31] tests/functional: replace 'run_cmd' with subprocess helpers, Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 28/31] tests/functional: replace 'run_cmd' with subprocess helpers, Thomas Huth <=
- [PATCH v2 27/31] tests/functional: drop back compat imports from utils.py, Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 27/31] tests/functional: drop back compat imports from utils.py, Thomas Huth, 2024/12/12
- [PATCH v2 29/31] tests/functional: remove now unused 'run_cmd' helper, Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 29/31] tests/functional: remove now unused 'run_cmd' helper, Thomas Huth, 2024/12/12
- [PATCH v2 30/31] tests/functional: skip tests if assets are not available, Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 30/31] tests/functional: skip tests if assets are not available, Thomas Huth, 2024/12/12
    - Re: [PATCH v2 30/31] tests/functional: skip tests if assets are not available, Daniel P . Berrangé, 2024/12/12
    - Re: [PATCH v2 30/31] tests/functional: skip tests if assets are not available, Thomas Huth, 2024/12/13
- [PATCH v2 31/31] tests/functional: ignore errors when caching assets, except for 404, Daniel P . Berrangé, 2024/12/11
  - Re: [PATCH v2 31/31] tests/functional: ignore errors when caching assets, except for 404, Thomas Huth, 2024/12/13

Prev by Date: Re: [PATCH v2] tests/functional: Convert the intel_iommu avocado test
Next by Date: Re: [PATCH v2 29/31] tests/functional: remove now unused 'run_cmd' helper
Previous by thread: [PATCH v2 28/31] tests/functional: replace 'run_cmd' with subprocess helpers
Next by thread: [PATCH v2 27/31] tests/functional: drop back compat imports from utils.py
Index(es):
- Date
- Thread