[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/22] tests/qtest: Use qtest_system_reset_nowait() where appropri
From: |
Fabiano Rosas |
Subject: |
[PULL 04/22] tests/qtest: Use qtest_system_reset_nowait() where appropriate |
Date: |
Thu, 12 Dec 2024 12:09:31 -0300 |
From: Peter Maydell <peter.maydell@linaro.org>
In the device and drive plug/unplug tests we want to trigger
a system reset and then see if we get the appropriate
DEVICE_DELETED event. Use qtest_system_reset_nowait() here.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
tests/qtest/device-plug-test.c | 11 +----------
tests/qtest/drive_del-test.c | 7 +------
2 files changed, 2 insertions(+), 16 deletions(-)
diff --git a/tests/qtest/device-plug-test.c b/tests/qtest/device-plug-test.c
index c6f33153eb..127a7f9efe 100644
--- a/tests/qtest/device-plug-test.c
+++ b/tests/qtest/device-plug-test.c
@@ -15,15 +15,6 @@
#include "qapi/qmp/qdict.h"
#include "qapi/qmp/qstring.h"
-static void system_reset(QTestState *qtest)
-{
- QDict *resp;
-
- resp = qtest_qmp(qtest, "{'execute': 'system_reset'}");
- g_assert(qdict_haskey(resp, "return"));
- qobject_unref(resp);
-}
-
static void wait_device_deleted_event(QTestState *qtest, const char *id)
{
QDict *resp, *data;
@@ -58,7 +49,7 @@ static void process_device_remove(QTestState *qtest, const
char *id)
* handled, removing the device.
*/
qtest_qmp_device_del_send(qtest, id);
- system_reset(qtest);
+ qtest_system_reset_nowait(qtest);
wait_device_deleted_event(qtest, id);
}
diff --git a/tests/qtest/drive_del-test.c b/tests/qtest/drive_del-test.c
index 7b67a4bbee..99f6fc2de1 100644
--- a/tests/qtest/drive_del-test.c
+++ b/tests/qtest/drive_del-test.c
@@ -154,15 +154,10 @@ static void device_add(QTestState *qts)
static void device_del(QTestState *qts, bool and_reset)
{
- QDict *response;
-
qtest_qmp_device_del_send(qts, "dev0");
if (and_reset) {
- response = qtest_qmp(qts, "{'execute': 'system_reset' }");
- g_assert(response);
- g_assert(qdict_haskey(response, "return"));
- qobject_unref(response);
+ qtest_system_reset_nowait(qts);
}
qtest_qmp_eventwait(qts, "DEVICE_DELETED");
--
2.35.3
- [PULL 00/22] QTest patches for 2024-12-12, Fabiano Rosas, 2024/12/12
- [PULL 02/22] tests/qtest: Add qtest_system_reset() utility function, Fabiano Rosas, 2024/12/12
- [PULL 01/22] tests/qtest: add TIMEOUT_MULTIPLIER, Fabiano Rosas, 2024/12/12
- [PULL 03/22] tests/qtest: Use qtest_system_reset() instead of open-coded versions, Fabiano Rosas, 2024/12/12
- [PULL 04/22] tests/qtest: Use qtest_system_reset_nowait() where appropriate,
Fabiano Rosas <=
- [PULL 05/22] tests/qtest/migration: Standardize hook names, Fabiano Rosas, 2024/12/12
- [PULL 06/22] tests/qtest/migration: Stop calling everything "test", Fabiano Rosas, 2024/12/12
- [PULL 07/22] tests/migration: Disambiguate guestperf vs. a-b, Fabiano Rosas, 2024/12/12
- [PULL 08/22] tests/qtest/migration: Move bootfile code to its own file, Fabiano Rosas, 2024/12/12
- [PULL 09/22] tests/qtest/migration: Move qmp helpers to a separate file, Fabiano Rosas, 2024/12/12
- [PULL 10/22] tests/qtest/migration: Rename migration-helpers.c, Fabiano Rosas, 2024/12/12
- [PULL 11/22] tests/qtest/migration: Move ufd_version_check to utils, Fabiano Rosas, 2024/12/12
- [PULL 12/22] tests/qtest/migration: Move kvm_dirty_ring_supported to utils, Fabiano Rosas, 2024/12/12
- [PULL 13/22] tests/qtest/migration: Isolate test initialization, Fabiano Rosas, 2024/12/12
- [PULL 15/22] tests/qtest/migration: Split TLS tests from migration-test.c, Fabiano Rosas, 2024/12/12