qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 43/46] tcg/optimize: Use finish_folding as default in tcg_opt


From: Pierrick Bouvier
Subject: Re: [PATCH 43/46] tcg/optimize: Use finish_folding as default in tcg_optimize
Date: Tue, 17 Dec 2024 12:46:11 -0800
User-agent: Mozilla Thunderbird

On 12/10/24 07:23, Richard Henderson wrote:
All non-default cases now finish folding within each function.
Do the same with the default case and assert it is done after.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
  tcg/optimize.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tcg/optimize.c b/tcg/optimize.c
index 24ec14f476..94e942e1cf 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -3085,11 +3085,9 @@ void tcg_optimize(TCGContext *s)
              done = true;
              break;
          default:
+            done = finish_folding(&ctx, op);
              break;
          }
-
-        if (!done) {
-            finish_folding(&ctx, op);
-        }
+        tcg_debug_assert(done);
      }
  }

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]