Re: [PATCH 41/46] tcg/optimize: Use fold_masks_zs in fold_xor

[Richard Henderson]

On 12/17/24 14:45, Pierrick Bouvier wrote:
> On 12/10/24 07:23, Richard Henderson wrote:
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   tcg/optimize.c | 17 +++++++----------
> >   1 file changed, 7 insertions(+), 10 deletions(-)
> >
> > diff --git a/tcg/optimize.c b/tcg/optimize.c
> > index 46116970f3..fec46014be 100644
> > --- a/tcg/optimize.c
> > +++ b/tcg/optimize.c
> > @@ -1093,11 +1093,6 @@ static bool fold_masks_z(OptContext *ctx, TCGOp *op, uint64_t 
> > z_mask)
> >       return fold_masks_zsa(ctx, op, z_mask, smask_from_zmask(z_mask), -1);
> >   }
> > -static bool fold_masks(OptContext *ctx, TCGOp *op)
> > -{
> > -    return fold_masks_zsa(ctx, op, ctx->z_mask, ctx->s_mask, ctx->a_mask);
> > -}
> > -
>
> Not so important, but eliminating this function could be done in its own commit.

No, we get a Werror for an unused function.


r~