Re: [PATCH] contrib/plugins/bbv.c: Start bb index from 1

[Pierrick Bouvier]

Hi,

On 12/17/24 06:24, ckf104 wrote:
> Standard simpoint tool reqeusts that index of basic block index starts from 1.
>
> Signed-off-by: ckf104 <1900011634@pku.edu.cn>
> ---
>   contrib/plugins/bbv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/contrib/plugins/bbv.c b/contrib/plugins/bbv.c
> index a5256517dd..b9da6f815e 100644
> --- a/contrib/plugins/bbv.c
> +++ b/contrib/plugins/bbv.c
> @@ -109,7 +109,7 @@ static void vcpu_tb_trans(qemu_plugin_id_t id, struct 
> qemu_plugin_tb *tb)
>           bb = g_new(Bb, 1);
>           bb->vaddr = vaddr;
>           bb->count = qemu_plugin_scoreboard_new(sizeof(uint64_t));
> -        bb->index = g_hash_table_size(bbs);
> +        bb->index = g_hash_table_size(bbs) + 1;
>           g_hash_table_replace(bbs, &bb->vaddr, bb);
>       }
>       g_rw_lock_writer_unlock(&bbs_lock);

thanks for this fix.

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>