Re: [PATCH] contrib/plugins/bbv.c: Start bb index from 1

[Pierrick Bouvier]

On 12/22/24 01:11, Michael Tokarev wrote:
> 17.12.2024 17:24, ckf104 wrote:
> > Standard simpoint tool reqeusts that index of basic block index starts from 1.
>
> While this patch is a trivial one-liner, but the underlying issue requires at 
> least
> a minimal understanding of what it is all about, what *is* bbv to begin with, 
> what
> `simpoint' is.  I'm not sure it really is a trivial material?

This fix is alright.
This plugin generated data for a binary analysis tool (named Simpoint) 
that needs specific data named basic block vectors (bbv).

I didn't use it myself, I trust this change.

> > Signed-off-by: ckf104 <1900011634@pku.edu.cn>
>
> Do we accept such SoBs these days?
>
> Thanks,
>
> /mjt