[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 04/10] i386/topology: Update the comment of x86_apicid_from_to
From: |
Xiaoyao Li |
Subject: |
[PATCH v2 04/10] i386/topology: Update the comment of x86_apicid_from_topo_ids() |
Date: |
Thu, 19 Dec 2024 06:01:19 -0500 |
Update the comment of x86_apicid_from_topo_ids() to match the current
implementation,
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
---
include/hw/i386/topology.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/hw/i386/topology.h b/include/hw/i386/topology.h
index b2c8bf2de158..21b65219a5ca 100644
--- a/include/hw/i386/topology.h
+++ b/include/hw/i386/topology.h
@@ -121,9 +121,10 @@ static inline unsigned apicid_pkg_offset(X86CPUTopoInfo
*topo_info)
}
/*
- * Make APIC ID for the CPU based on Pkg_ID, Core_ID, SMT_ID
+ * Make APIC ID for the CPU based on topology and IDs of each topology level.
*
- * The caller must make sure core_id < nr_cores and smt_id < nr_threads.
+ * The caller must make sure the ID of each level doesn't exceed the width of
+ * the level.
*/
static inline apic_id_t x86_apicid_from_topo_ids(X86CPUTopoInfo *topo_info,
const X86CPUTopoIDs *topo_ids)
--
2.34.1
- [PATCH v2 00/10] i386: Track X86CPUTopoInfo in CPUX86State and track features in env->features[], Xiaoyao Li, 2024/12/19
- [PATCH v2 01/10] i386/cpu: Extract a common fucntion to setup value of MSR_CORE_THREAD_COUNT, Xiaoyao Li, 2024/12/19
- [PATCH v2 04/10] i386/topology: Update the comment of x86_apicid_from_topo_ids(),
Xiaoyao Li <=
- [PATCH v2 03/10] i386/cpu: Drop cores_per_pkg in cpu_x86_cpuid(), Xiaoyao Li, 2024/12/19
- [PATCH v2 05/10] i386/topology: Introduce helpers for various topology info of different level, Xiaoyao Li, 2024/12/19
- [PATCH v2 06/10] i386/cpu: Track a X86CPUTopoInfo directly in CPUX86State, Xiaoyao Li, 2024/12/19
- [PATCH v2 02/10] i386/cpu: Drop the variable smp_cores and smp_threads in x86_cpu_pre_plug(), Xiaoyao Li, 2024/12/19
- [PATCH v2 07/10] i386/cpu: Hoist check of CPUID_EXT3_TOPOEXT against threads_per_core, Xiaoyao Li, 2024/12/19