[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 03/10] i386/cpu: Drop cores_per_pkg in cpu_x86_cpuid()
From: |
Xiaoyao Li |
Subject: |
[PATCH v2 03/10] i386/cpu: Drop cores_per_pkg in cpu_x86_cpuid() |
Date: |
Thu, 19 Dec 2024 06:01:18 -0500 |
Local variable cores_per_pkg is only used to calculate threads_per_pkg.
No need for it. Drop it and open-code it instead.
Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
---
target/i386/cpu.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 525339945920..ad6889abdf5e 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -6498,7 +6498,6 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index,
uint32_t count,
uint32_t limit;
uint32_t signature[3];
X86CPUTopoInfo topo_info;
- uint32_t cores_per_pkg;
uint32_t threads_per_pkg;
topo_info.dies_per_pkg = env->nr_dies;
@@ -6506,9 +6505,8 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index,
uint32_t count,
topo_info.cores_per_module = cs->nr_cores / env->nr_dies / env->nr_modules;
topo_info.threads_per_core = cs->nr_threads;
- cores_per_pkg = topo_info.cores_per_module * topo_info.modules_per_die *
- topo_info.dies_per_pkg;
- threads_per_pkg = cores_per_pkg * topo_info.threads_per_core;
+ threads_per_pkg = topo_info.threads_per_core * topo_info.cores_per_module *
+ topo_info.modules_per_die * topo_info.dies_per_pkg;
/* Calculate & apply limits for different index ranges */
if (index >= 0xC0000000) {
--
2.34.1
- [PATCH v2 00/10] i386: Track X86CPUTopoInfo in CPUX86State and track features in env->features[], Xiaoyao Li, 2024/12/19
- [PATCH v2 01/10] i386/cpu: Extract a common fucntion to setup value of MSR_CORE_THREAD_COUNT, Xiaoyao Li, 2024/12/19
- [PATCH v2 04/10] i386/topology: Update the comment of x86_apicid_from_topo_ids(), Xiaoyao Li, 2024/12/19
- [PATCH v2 03/10] i386/cpu: Drop cores_per_pkg in cpu_x86_cpuid(),
Xiaoyao Li <=
- [PATCH v2 05/10] i386/topology: Introduce helpers for various topology info of different level, Xiaoyao Li, 2024/12/19
- [PATCH v2 06/10] i386/cpu: Track a X86CPUTopoInfo directly in CPUX86State, Xiaoyao Li, 2024/12/19
- [PATCH v2 02/10] i386/cpu: Drop the variable smp_cores and smp_threads in x86_cpu_pre_plug(), Xiaoyao Li, 2024/12/19
- [PATCH v2 07/10] i386/cpu: Hoist check of CPUID_EXT3_TOPOEXT against threads_per_core, Xiaoyao Li, 2024/12/19
- [PATCH v2 08/10] cpu: Remove nr_cores from struct CPUState, Xiaoyao Li, 2024/12/19