Re: [PULL 00/15] Host Memory Backends and Memory devices queue 2024-12-18

[David Hildenbrand]

On 19.12.24 12:43, Christian Borntraeger wrote:
> Am 19.12.24 um 12:18 schrieb David Hildenbrand:
> > The following on top seems to make everything happy. I wish the
> > CONFIG_S390_CCW_VIRTIO stuff would't have to be so complicated, just to
> > handle odd configs that don't really make sense.
>
> WOuld it be possible to rid of this config?

I was asking myself the same: when does it make sense to build for s390x 
system without CONFIG_S390_CCW_VIRTIO. But other archs that also have a 
single machine seem to be doing the same thing.

We wouldn't want to have the option to disable it, but "bool" gives you 
the option to do that.

I suspect something that could work is:

diff --git a/target/s390x/Kconfig b/target/s390x/Kconfig
index 8a95f2bc3f..4c99b9cedd 100644
--- a/target/s390x/Kconfig
+++ b/target/s390x/Kconfig
@@ -1,5 +1,6 @@
 config S390X
     bool
+    select CONFIG_S390_CCW_VIRTIO
     select PCI
     select S390_FLIC



--
Cheers,

David / dhildenb