[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 12/17] hw/ide: Fix record-replay and convert to new bh API
From: |
Nicholas Piggin |
Subject: |
[PATCH 12/17] hw/ide: Fix record-replay and convert to new bh API |
Date: |
Fri, 20 Dec 2024 20:42:14 +1000 |
Convert qemu_bh_schedule() to qemu_bh_schedule_event(), which can
specify the clock type, making it compatible with record-replay.
Restarting the IDE device does affect target machine state, so it should
use QEMU_CLOCK_VIRTUAL to recorded and replay the bh.
This fixes hangs in record/replay when using IDE devices.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
hw/ide/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index c527caf3d69..500ea73c8be 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -2780,7 +2780,7 @@ static void ide_restart_cb(void *opaque, bool running,
RunState state)
if (!bus->bh) {
bus->bh = qemu_bh_new(ide_restart_bh, bus);
- qemu_bh_schedule(bus->bh);
+ qemu_bh_schedule_event(bus->bh, QEMU_CLOCK_VIRTUAL);
}
}
--
2.45.2
- Re: [PATCH 02/17] replay: Fix migration replay_mutex locking, (continued)
- [PATCH 03/17] async: rework async event API for replay, Nicholas Piggin, 2024/12/20
- [PATCH 04/17] util/main-loop: Convert to new bh API, Nicholas Piggin, 2024/12/20
- [PATCH 05/17] util/thread-pool: Convert to new bh API, Nicholas Piggin, 2024/12/20
- [PATCH 06/17] util/aio-wait: Convert to new bh API, Nicholas Piggin, 2024/12/20
- [PATCH 07/17] async/coroutine: Convert to new bh API, Nicholas Piggin, 2024/12/20
- [PATCH 08/17] migration: Convert to new bh API, Nicholas Piggin, 2024/12/20
- [PATCH 09/17] monitor: Convert to new bh API, Nicholas Piggin, 2024/12/20
- [PATCH 10/17] qmp: Convert to new bh API, Nicholas Piggin, 2024/12/20
- [PATCH 11/17] block: Convert to new bh API, Nicholas Piggin, 2024/12/20
- [PATCH 12/17] hw/ide: Fix record-replay and convert to new bh API,
Nicholas Piggin <=
- [PATCH 13/17] hw/scsi: Convert to new bh API, Nicholas Piggin, 2024/12/20
- [PATCH 14/17] async: add debugging assertions for record/replay in bh APIs, Nicholas Piggin, 2024/12/20
- [PATCH 15/17] tests/avocado/replay_linux: Fix compile error, Nicholas Piggin, 2024/12/20
- [PATCH 16/17] tests/avocado/replay_linux: Fix cdrom device setup, Nicholas Piggin, 2024/12/20
- [PATCH 17/17] tests/avocado/replay_linux: remove the timeout expected guards, Nicholas Piggin, 2024/12/20
- Re: [PATCH 00/17] replay: Fixes and avocado test updates, Pavel Dovgalyuk, 2024/12/20