qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 13/17] hw/scsi: Convert to new bh API


From: Paolo Bonzini
Subject: Re: [PATCH 13/17] hw/scsi: Convert to new bh API
Date: Sat, 21 Dec 2024 00:54:07 +0100



Il ven 20 dic 2024, 11:44 Nicholas Piggin <npiggin@gmail.com> ha scritto:
Convert aio_bh_schedule_oneshot() to aio_bh_schedule_oneshot_event(),
which can specify the clock type, making it compatible with
record-replay.

Operations on SCSI reqs do affect target machine state, so it should
use QEMU_CLOCK_VIRTUAL to recorded and replay the bh.

This does not seem to match the patch below?

Paolo 

+    aio_bh_schedule_oneshot_event(blk_get_aio_context(s->conf.blk),
+                                  scsi_device_for_each_req_async_bh,
+                                  data, QEMU_CLOCK_REALTIME);
 }

 static void scsi_device_realize(SCSIDevice *s, Error **errp)
--
2.45.2


reply via email to

[Prev in Thread] Current Thread [Next in Thread]