Re: [PATCH v2 0/7] migration: Drop/unexport migration_is_device() and migration_is_active()

[Peter Xu]

On Tue, Dec 24, 2024 at 09:20:08AM +0100, Cédric Le Goater wrote:
> Fabiano, Peter,
> 
> On 12/18/24 14:40, Avihai Horon wrote:
> > Hello,
> > 
> > This follows up on Peter's series [1] to simplify migration status API
> > to a single migration_is_running() function.
> > 
> > Peter's series tried to drop migration_is_device() and
> > migration_is_active(), however VFIO used them to check if dirty page
> > tracking has been started in order to avoid errors in log sync, so they
> > couldn't simply be dropped without some preliminary cleanups.
> > 
> > This series handles these preliminary cleanups and eventually drops
> > migration_is_device() and unexports migration_is_active().
> > 
> > The series has been migration tested with the following:
> > - VFIO device dirty tracking.
> > - Legacy VFIO iommu dirty tracking.
> > - vIOMMU + Legacy VFIO iommu dirty tracking (migration with vIOMMU is
> >    currently blocked, so I used a patched QEMU to allow it).
> > 
> > I also tested calc-dirty-rate as now VFIO dirty pages should be included
> > in its report, and indeed they are.
> > 
> > I didn't test it with iommu DPT as I don't have access to such HW.
> > It would be great if someone with the proper HW could test it.
> > 
> > Patch structure:
> > 1-4: Refactor and clean up VFIO dirty page tracking helpers.
> > 5: Refactor dirty limit code.
> > 6-7: Drop/unexport migration_is_device() and migration_is_running().
> 
> I can take these migration changes through the VFIO queue.
> Is that ok for you ?

Fabiano is collecting things for this cycle, but just in case he's in the
middle of a party - yes please, thanks!

-- 
Peter Xu