[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 25/72] tcg/optimize: Use fold_masks_zs in fold_movcond
From: |
Richard Henderson |
Subject: |
[PULL 25/72] tcg/optimize: Use fold_masks_zs in fold_movcond |
Date: |
Tue, 24 Dec 2024 12:04:34 -0800 |
Avoid the use of the OptContext slots. Find TempOptInfo once.
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/optimize.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/tcg/optimize.c b/tcg/optimize.c
index f62e7adfe1..0104582b3a 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -1889,6 +1889,8 @@ static bool fold_mov(OptContext *ctx, TCGOp *op)
static bool fold_movcond(OptContext *ctx, TCGOp *op)
{
+ uint64_t z_mask, s_mask;
+ TempOptInfo *tt, *ft;
int i;
/* If true and false values are the same, eliminate the cmp. */
@@ -1910,14 +1912,14 @@ static bool fold_movcond(OptContext *ctx, TCGOp *op)
return tcg_opt_gen_mov(ctx, op, op->args[0], op->args[4 - i]);
}
- ctx->z_mask = arg_info(op->args[3])->z_mask
- | arg_info(op->args[4])->z_mask;
- ctx->s_mask = arg_info(op->args[3])->s_mask
- & arg_info(op->args[4])->s_mask;
+ tt = arg_info(op->args[3]);
+ ft = arg_info(op->args[4]);
+ z_mask = tt->z_mask | ft->z_mask;
+ s_mask = tt->s_mask & ft->s_mask;
- if (arg_is_const(op->args[3]) && arg_is_const(op->args[4])) {
- uint64_t tv = arg_info(op->args[3])->val;
- uint64_t fv = arg_info(op->args[4])->val;
+ if (ti_is_const(tt) && ti_is_const(ft)) {
+ uint64_t tv = ti_const_val(tt);
+ uint64_t fv = ti_const_val(ft);
TCGOpcode opc, negopc = 0;
TCGCond cond = op->args[5];
@@ -1956,7 +1958,8 @@ static bool fold_movcond(OptContext *ctx, TCGOp *op)
}
}
}
- return false;
+
+ return fold_masks_zs(ctx, op, z_mask, s_mask);
}
static bool fold_mul(OptContext *ctx, TCGOp *op)
--
2.43.0
- [PULL 01/72] tests/tcg: Do not use inttypes.h in multiarch/system/memory.c, (continued)
- [PULL 01/72] tests/tcg: Do not use inttypes.h in multiarch/system/memory.c, Richard Henderson, 2024/12/24
- [PULL 04/72] tcg/optimize: Split out fold_affected_mask, Richard Henderson, 2024/12/24
- [PULL 07/72] tcg/optimize: Augment s_mask from z_mask in fold_masks_zs, Richard Henderson, 2024/12/24
- [PULL 09/72] tcg/optimize: Use finish_folding in fold_add, fold_add_vec, fold_addsub2, Richard Henderson, 2024/12/24
- [PULL 10/72] tcg/optimize: Introduce const value accessors for TempOptInfo, Richard Henderson, 2024/12/24
- [PULL 06/72] tcg/optimize: Split out fold_masks_zs, Richard Henderson, 2024/12/24
- [PULL 12/72] tcg/optimize: Use fold_masks_zs in fold_andc, Richard Henderson, 2024/12/24
- [PULL 14/72] tcg/optimize: Use fold_masks_zs in fold_count_zeros, Richard Henderson, 2024/12/24
- [PULL 16/72] tcg/optimize: Use fold_and and fold_masks_z in fold_deposit, Richard Henderson, 2024/12/24
- [PULL 19/72] tcg/optimize: Use finish_folding in fold_dup, fold_dup2, Richard Henderson, 2024/12/24
- [PULL 25/72] tcg/optimize: Use fold_masks_zs in fold_movcond,
Richard Henderson <=
- [PULL 03/72] tcg/optimize: Split out finish_bb, finish_ebb, Richard Henderson, 2024/12/24
- [PULL 08/72] tcg/optimize: Change representation of s_mask, Richard Henderson, 2024/12/24
- [PULL 05/72] tcg/optimize: Copy mask writeback to fold_masks, Richard Henderson, 2024/12/24
- [PULL 13/72] tcg/optimize: Use fold_masks_zs in fold_bswap, Richard Henderson, 2024/12/24
- [PULL 15/72] tcg/optimize: Use fold_masks_z in fold_ctpop, Richard Henderson, 2024/12/24
- [PULL 17/72] tcg/optimize: Compute sign mask in fold_deposit, Richard Henderson, 2024/12/24
- [PULL 18/72] tcg/optimize: Use finish_folding in fold_divide, Richard Henderson, 2024/12/24
- [PULL 21/72] tcg/optimize: Use fold_masks_z in fold_extract, Richard Henderson, 2024/12/24
- [PULL 24/72] tcg/optimize: Use fold_masks_z in fold_extu, Richard Henderson, 2024/12/24
- [PULL 26/72] tcg/optimize: Use finish_folding in fold_mul*, Richard Henderson, 2024/12/24