[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 21/72] tcg/optimize: Use fold_masks_z in fold_extract
From: |
Richard Henderson |
Subject: |
[PULL 21/72] tcg/optimize: Use fold_masks_z in fold_extract |
Date: |
Tue, 24 Dec 2024 12:04:30 -0800 |
Avoid the use of the OptContext slots. Find TempOptInfo once.
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
tcg/optimize.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/tcg/optimize.c b/tcg/optimize.c
index f948cc48c9..8111c120af 100644
--- a/tcg/optimize.c
+++ b/tcg/optimize.c
@@ -1739,25 +1739,22 @@ static bool fold_eqv(OptContext *ctx, TCGOp *op)
static bool fold_extract(OptContext *ctx, TCGOp *op)
{
uint64_t z_mask_old, z_mask;
+ TempOptInfo *t1 = arg_info(op->args[1]);
int pos = op->args[2];
int len = op->args[3];
- if (arg_is_const(op->args[1])) {
- uint64_t t;
-
- t = arg_info(op->args[1])->val;
- t = extract64(t, pos, len);
- return tcg_opt_gen_movi(ctx, op, op->args[0], t);
+ if (ti_is_const(t1)) {
+ return tcg_opt_gen_movi(ctx, op, op->args[0],
+ extract64(ti_const_val(t1), pos, len));
}
- z_mask_old = arg_info(op->args[1])->z_mask;
+ z_mask_old = t1->z_mask;
z_mask = extract64(z_mask_old, pos, len);
if (pos == 0 && fold_affected_mask(ctx, op, z_mask_old ^ z_mask)) {
return true;
}
- ctx->z_mask = z_mask;
- return fold_masks(ctx, op);
+ return fold_masks_z(ctx, op, z_mask);
}
static bool fold_extract2(OptContext *ctx, TCGOp *op)
--
2.43.0
- [PULL 16/72] tcg/optimize: Use fold_and and fold_masks_z in fold_deposit, (continued)
- [PULL 16/72] tcg/optimize: Use fold_and and fold_masks_z in fold_deposit, Richard Henderson, 2024/12/24
- [PULL 19/72] tcg/optimize: Use finish_folding in fold_dup, fold_dup2, Richard Henderson, 2024/12/24
- [PULL 25/72] tcg/optimize: Use fold_masks_zs in fold_movcond, Richard Henderson, 2024/12/24
- [PULL 03/72] tcg/optimize: Split out finish_bb, finish_ebb, Richard Henderson, 2024/12/24
- [PULL 08/72] tcg/optimize: Change representation of s_mask, Richard Henderson, 2024/12/24
- [PULL 05/72] tcg/optimize: Copy mask writeback to fold_masks, Richard Henderson, 2024/12/24
- [PULL 13/72] tcg/optimize: Use fold_masks_zs in fold_bswap, Richard Henderson, 2024/12/24
- [PULL 15/72] tcg/optimize: Use fold_masks_z in fold_ctpop, Richard Henderson, 2024/12/24
- [PULL 17/72] tcg/optimize: Compute sign mask in fold_deposit, Richard Henderson, 2024/12/24
- [PULL 18/72] tcg/optimize: Use finish_folding in fold_divide, Richard Henderson, 2024/12/24
- [PULL 21/72] tcg/optimize: Use fold_masks_z in fold_extract,
Richard Henderson <=
- [PULL 24/72] tcg/optimize: Use fold_masks_z in fold_extu, Richard Henderson, 2024/12/24
- [PULL 26/72] tcg/optimize: Use finish_folding in fold_mul*, Richard Henderson, 2024/12/24
- [PULL 29/72] tcg/optimize: Use fold_masks_s in fold_nor, Richard Henderson, 2024/12/24
- [PULL 30/72] tcg/optimize: Use fold_masks_s in fold_not, Richard Henderson, 2024/12/24
- [PULL 32/72] tcg/optimize: Use fold_masks_zs in fold_orc, Richard Henderson, 2024/12/24
- [PULL 31/72] tcg/optimize: Use fold_masks_zs in fold_or, Richard Henderson, 2024/12/24
- [PULL 34/72] tcg/optimize: Return true from fold_qemu_st, fold_tcg_st, Richard Henderson, 2024/12/24
- [PULL 35/72] tcg/optimize: Use finish_folding in fold_remainder, Richard Henderson, 2024/12/24
- [PULL 02/72] plugins: optimize cpu_index code generation, Richard Henderson, 2024/12/24
- [PULL 23/72] tcg/optimize: Use fold_masks_zs in fold_exts, Richard Henderson, 2024/12/24