Re: [PATCH v3 0/5] hppa CPU reset and speedup

[Philippe Mathieu-Daudé]

On 30/12/24 21:39, Philippe Mathieu-Daudé wrote:
> On 30/12/24 21:24, Helge Deller wrote:
> > Hi Philippe,
> >
> > On 12/30/24 16:25, Philippe Mathieu-Daudé wrote:
> > > Respin of:
> > > https://lore.kernel.org/qemu-devel/20241229234154.32250-1- 
> > > deller@kernel.org/
> > > "Add CPU reset function and speed up runtime and translation."
> > >
> > > - Remove hppa_cpu_init()
> >
> > Thanks for picking up my patches and integrating them properly
> > with the reset code.
> > But sadly your changes somehow break hppa 64-bit CPU support.
> > I think it's to when the reset code is called.
>
> Likely hppa_is_pa20() called *before* CPU reset...?

Indeed:

(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.10
  * frame #0: 0x000000010024df30 qemu-system-hppa`hppa_ptlbe [inlined] 
hppa_is_pa20(env=0x000000011f822230) at cpu.h:304:17
    frame #1: 0x000000010024df30 qemu-system-hppa`hppa_ptlbe [inlined] 
HPPA_BTLB_ENTRIES(env=0x000000011f822230) at cpu.h:309:12
    frame #2: 0x000000010024df30 
qemu-system-hppa`hppa_ptlbe(env=0x000000011f822230) at mem_helper.c:642:29
    frame #3: 0x0000000100250564 
qemu-system-hppa`hppa_cpu_realizefn(dev=0x000000011f81fa00, 
errp=<unavailable>) at cpu.c:188:9
    frame #4: 0x00000001002f812c 
qemu-system-hppa`device_set_realized(obj=<unavailable>, 
value=<unavailable>, errp=0x000000016fdfebc0) at qdev.c:495:13

> > Easy reproducer (no other options/disc/network needed):
> > ./qemu-system-hppa -smp cpus=4 -nographic -machine C3700