Re: [PATCH v3 0/5] hppa CPU reset and speedup

[Helge Deller]

On 12/30/24 21:36, Philippe Mathieu-Daudé wrote:
> On 30/12/24 21:24, Helge Deller wrote:
> > Hi Philippe,
> >
> > On 12/30/24 16:25, Philippe Mathieu-Daudé wrote:
> > > Respin of:
> > > https://lore.kernel.org/qemu-devel/20241229234154.32250-1- deller@kernel.org/
> > > "Add CPU reset function and speed up runtime and translation."
> > >
> > > - Remove hppa_cpu_init()
> >
> > Thanks for picking up my patches and integrating them properly
> > with the reset code.
> > But sadly your changes somehow break hppa 64-bit CPU support.
> > I think it's to when the reset code is called.
> >
> > Easy reproducer (no other options/disc/network needed):
> > ./qemu-system-hppa -smp cpus=4 -nographic -machine C3700
>
> [*]
>
> > > - Reset PSW using M bit (untested)
> >
> > We haven't implemented PSW-M support and the first
> > thing the firmware does is to reprogram PSW.
> > So, basically it's not needed.
> >
> > > Helge, could we add a functional test booting Linux?
> >
> > What exactly are you looking for?
> > Some trivial preinstalled disc image with kernels?
> > Any examples?
>
> Your [*] example running SeaBIOS is perfect.
>
> See tests/functional/test_riscv_opensbi.py, but using:
>
>    wait_for_console_pattern('SeaBIOS PA-RISC 64-bit Firmware')

Then I suggest 2 testcases (32-bit and 64-bit CPU, dropped SMP flag):
./qemu-system-hppa -nographic -machine B160L
./qemu-system-hppa -nographic -machine C3700

Helge

> > Helge
> >
> > > Helge Deller (4):
> > >    target/hppa: Convert hppa_cpu_init() to ResetHold handler
> > >    hw/hppa: Reset vCPUs calling resettable_reset()
> > >    target/hppa: Set PC on vCPU reset
> > >    target/hppa: Speed up hppa_is_pa20()
> > >
> > > Philippe Mathieu-Daudé (1):
> > >    target/hppa: Only set PSW 'M' bit on reset
> > >
> > >   target/hppa/cpu.h | 11 +++++++++--
> > >   hw/hppa/machine.c |  6 +++---
> > >   target/hppa/cpu.c | 20 +++++++++++++++++---
> > >   3 files changed, 29 insertions(+), 8 deletions(-)