[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v3 10/13] nvdimm: convert nvdimm_mr into a pointer
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-ppc] [PATCH v3 10/13] nvdimm: convert nvdimm_mr into a pointer |
Date: |
Mon, 18 Jun 2018 12:51:56 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 18.06.2018 02:49, David Gibson wrote:
> On Fri, Jun 15, 2018 at 04:04:45PM +0200, David Hildenbrand wrote:
>> This way we can easily check if the region has already been inititalized
>> without having to rely on the size of an uninitialized region being 0.
>>
>> Signed-off-by: David Hildenbrand <address@hidden>
>
> I'm not terribly convinced that this is a worthwhile change, but in
> the sense that the patch appears to be technically correct:
>
Igor requested this, and as I had no strong feelings about it, I
included it. At least we are not able to hand out "uninitialized
regions" this way anymore.
Thanks!
--
Thanks,
David / dhildenb
- [Qemu-ppc] [PATCH v3 04/13] pc-dimm: remove pc_dimm_get_free_slot() from header, (continued)
- [Qemu-ppc] [PATCH v3 04/13] pc-dimm: remove pc_dimm_get_free_slot() from header, David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 05/13] pc: factor out pc specific dimm checks into pc_memory_pre_plug(), David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 06/13] nvdimm: no need to overwrite get_vmstate_memory_region(), David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 08/13] pc-dimm: merge get_(vmstate_)memory_region(), David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 07/13] hostmem: drop error variable from host_memory_backend_get_memory(), David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 10/13] nvdimm: convert nvdimm_mr into a pointer, David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 11/13] nvdimm: allow setting the label-size to 0, David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 12/13] nvdimm: make get_memory_region() perform checks and initialization, David Hildenbrand, 2018/06/15
- [Qemu-ppc] [PATCH v3 09/13] nvdimm: convert "unarmed" into a static property, David Hildenbrand, 2018/06/15