[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 10/15] target/ppc: Fix arguments to ppc_radix64_partition_scoped_x
From: |
David Gibson |
Subject: |
[PULL 10/15] target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate() |
Date: |
Wed, 27 May 2020 15:38:04 +1000 |
From: Greg Kurz <address@hidden>
The last two arguments have the bool type. Also, we shouldn't raise an
exception when using gdbstub.
This was found while reading the code. Since it only affects the powernv
machine, I didn't dig further to find an actual bug.
Fixes: d04ea940c597 "target/ppc: Add support for Radix partition-scoped
translation"
Signed-off-by: Greg Kurz <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
Signed-off-by: David Gibson <address@hidden>
---
target/ppc/mmu-radix64.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
index fb7dfe25ba..7ce37cb778 100644
--- a/target/ppc/mmu-radix64.c
+++ b/target/ppc/mmu-radix64.c
@@ -339,7 +339,8 @@ static int ppc_radix64_process_scoped_xlate(PowerPCCPU
*cpu, int rwx,
*/
ret = ppc_radix64_partition_scoped_xlate(cpu, 0, eaddr, prtbe_addr,
pate, &h_raddr, &h_prot,
- &h_page_size, 1, 1);
+ &h_page_size, true,
+ cause_excp);
if (ret) {
return ret;
}
@@ -378,7 +379,8 @@ static int ppc_radix64_process_scoped_xlate(PowerPCCPU
*cpu, int rwx,
do {
ret = ppc_radix64_partition_scoped_xlate(cpu, 0, eaddr, pte_addr,
pate, &h_raddr, &h_prot,
- &h_page_size, 1, 1);
+ &h_page_size, true,
+ cause_excp);
if (ret) {
return ret;
}
--
2.26.2
- [PULL 00/15] ppc-for-5.1 queue 20200527, David Gibson, 2020/05/27
- [PULL 03/15] target/ppc: Untabify excp_helper.c, David Gibson, 2020/05/27
- [PULL 01/15] ppc/pnv: Fix NMI system reset SRR1 value, David Gibson, 2020/05/27
- [PULL 08/15] target/ppc: Don't initialize some local variables in ppc_radix64_xlate(), David Gibson, 2020/05/27
- [PULL 05/15] ppc/spapr: Add hotremovable flag on DIMM LMBs on drmem_v2, David Gibson, 2020/05/27
- [PULL 02/15] ppc/spapr: add a POWER10 CPU model, David Gibson, 2020/05/27
- [PULL 10/15] target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate(),
David Gibson <=
- [PULL 07/15] target/ppc: Pass const pointer to ppc_radix64_get_fully_qualified_addr(), David Gibson, 2020/05/27
- [PULL 06/15] target/ppc: Pass const pointer to ppc_radix64_get_prot_amr(), David Gibson, 2020/05/27
- [PULL 12/15] hw/pci-bridge/dec: Remove dead debug code, David Gibson, 2020/05/27
- [PULL 04/15] target/ppc: Add support for scv and rfscv instructions, David Gibson, 2020/05/27
- [PULL 09/15] target/ppc: Add missing braces in ppc_radix64_partition_scoped_xlate(), David Gibson, 2020/05/27
- [PULL 11/15] target/ppc: Don't update radix PTE R/C bits with gdbstub, David Gibson, 2020/05/27
- [PULL 14/15] target/ppc: Fix argument to ppc_radix64_partition_scoped_xlate() again, David Gibson, 2020/05/27
- [PULL 13/15] hw/nvram/mac_nvram: Convert debug printf()s to trace events, David Gibson, 2020/05/27
- [PULL 15/15] vfio/nvlink: Remove exec permission to avoid SELinux AVCs, David Gibson, 2020/05/27
- Re: [PULL 00/15] ppc-for-5.1 queue 20200527, no-reply, 2020/05/27